Bug 159898 - Writer context menu displays greyed out non-available options
Summary: Writer context menu displays greyed out non-available options
Status: RESOLVED DUPLICATE of bug 158101
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://ask.libreoffice.org/t/right-c...
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2024-02-26 08:58 UTC by David Robley
Modified: 2024-02-27 19:48 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Writer Right-Click Menu - Comparing LO 24.2.0 vs. 7.3.7 (50.66 KB, image/png)
2024-02-26 21:17 UTC, Tex2002ans
Details
LO 24.2.0 with DontHideDisabledEntry set to "false" (11.91 KB, image/png)
2024-02-27 06:14 UTC, Tex2002ans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Robley 2024-02-26 08:58:56 UTC
Description:
The context menu in Writer 24.2.0.3 for paragraph includes greyed out options which are not relevant to the current context. Another user has confirmed that this does not happen with version 7.6.5.2

See discussion and screen captures at https://ask.libreoffice.org/t/102585/6

Steps to Reproduce:
1.Open a new Writer document
2.Right click
3.

Actual Results:
Context menu displays non relevant options greyed out as well as available options

Expected Results:
Only available options should be displayed


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: 420(Build:3)
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (wbp_AU.UTF-8); UI: en-US
SlackBuild for 24.2.0 by Eric Hameleers
Calc: threaded
Comment 1 ajlittoz 2024-02-26 09:04:00 UTC
I confirm this does not happen in 7.6.5.2 (Fedora 39 [Linux], KDE Plasma desktop) where a more compact context menu is more useful (not occupying too much screen area).

This can be considered a UX regression.
Comment 2 Tex2002ans 2024-02-26 21:16:20 UTC
Looks like a user (x69pr) on the LibreOffice subreddit had this same issue too:

- https://www.reddit.com/r/libreoffice/comments/1azkkmu/how_to_remove_these_grayedout_right_click_context/

- - -

Steps to Reproduce

In Writer:

1. Right-Click a word in a paragraph.

REGRESSION: See a HUGE LIST of grayed out choices.

- - -

Looks like I can see this too in:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

I also tested:

- LO 7.3.7 and saw a minimal Right-Click menu.

See attached image comparing both versions.
Comment 3 Tex2002ans 2024-02-26 21:17:16 UTC
Created attachment 192805 [details]
Writer Right-Click Menu - Comparing LO 24.2.0 vs. 7.3.7
Comment 4 m_a_riosv 2024-02-26 22:21:04 UTC
Maybe I'm wrong, but I think this was done on purpose.
I can't find the related bug.
Comment 5 Tex2002ans 2024-02-27 02:23:02 UTC
I couldn't reproduce on Linux (LO 7.6 or 24.2 GTK3)...

But I WAS able to reproduce+bibisect it on Windows.

(This is my very first bibisect, so hopefully it's correct.)

- - -

I bibisected it down to:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a0955317900075371d6adb7f924af24c22f02d09

- - -

author	Jim Raykowski <raykowj@gmail.com>	2023-09-15 21:26:32 -0800
committer	Jim Raykowski <raykowj@gmail.com>	2023-09-27 07:12:30 +0200
commit a0955317900075371d6adb7f924af24c22f02d09 (patch)
tree c5194d62d6f7f9935e7f4d7a191b6283205b6613
parent c2930ebff82c4f7ffe8377ab82627131f8544226 (diff)
tdf#139935 Part B: Show all menu items possible/potential actions,
but grey-out and deactivate, when not applicable

This patch makes VCL PopupMenu respect the
officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting.

Change-Id: I4df0de82585b602e12481ae46bc4f94c2588970d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156979
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Comment 6 David Robley 2024-02-27 04:32:25 UTC
In reply to Tex2002ans comment:

It transpires that the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting is configurable via expert configuration. Thus it seems the change is intentional and not a bug.

To change the setting, go to Tools | Options | LibreOffice | Advanced and click on Open Expert Configuration.

In the Search field type disabledentry and click Search. This will display the relevant entry; double click to toggle the value.
Comment 7 Tex2002ans 2024-02-27 06:14:06 UTC
Created attachment 192814 [details]
LO 24.2.0 with DontHideDisabledEntry set to "false"

(In reply to David Robley from comment #6)
> the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting is
> configurable via expert configuration. [...]

Yep, that does it.

Attached is an image showing LO 24.2.0 with "DontHideDisabledEntry" set to false.

- - -

For those who want to go back to the minimal menu...

Go to:

1. Tools > Options
2. LibreOffice > Advanced
3. Click on the "Open Expert Configuration" button.

Now, in the "Expert Configuration" window:

4. Click in the search bar up top and type in:
   - DontHideDisabledEntry
5. Press the "Search" button.
6. Double-click on the row with "DontHideDisabledEntry" to set it from true -> false.
7. Press OK.

- - -

> Thus it seems the change is intentional and not a bug.

Also CCing Jim, since it was his change I bibisected to.

- - -

Side Note: Also weird, do these Expert configs usually have "double negatives"?

- "Hide Disabled Entry"
   = Enabled means "YES hide"
   = Disabled means "NO hide"

vs. the current:

- "Don't Hide Disabled Entry"
   = Enabled means "YES DO NOT hide!"
   = Disabled means "NO DO NOT hide!"

seems pretty confusing to me.
Comment 8 Heiko Tietze 2024-02-27 08:03:35 UTC
I don't remember why I agreed to this. Of course we should carefully hide entries that don't apply at all and show disabled if temporarily unavailable. But wasn't this fixed for bug 158101?

*** This bug has been marked as a duplicate of bug 158101 ***
Comment 9 Tex2002ans 2024-02-27 19:48:34 UTC
> But wasn't this fixed for bug 158101?

Yep, it looks like it!

Thanks Heiko for more info + thanks Jim for already preemptively fixing this for 24.2.1! :)