Bug 160025 - macos: Visible glitch: Highlighting of tabs is not correct
Summary: macos: Visible glitch: Highlighting of tabs is not correct
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.2.1.2 release
Hardware: All macOS (All)
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected
Depends on:
Blocks: Fields-Dialog
  Show dependency treegraph
 
Reported: 2024-03-04 12:02 UTC by Dennis Roczek
Modified: 2024-12-14 19:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Optical glitch (16.94 KB, image/jpeg)
2024-03-04 12:03 UTC, Dennis Roczek
Details
Screenshot 2024-03-04 no repro intel, us (250.72 KB, image/png)
2024-03-04 14:04 UTC, steve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Roczek 2024-03-04 12:02:35 UTC
Description:
see screenshot: the highlighting of the tabs in the field menu is a bit moved and not correctly around the tab.

Steps to Reproduce:
Choose Insert - Field - More Fields - Functions tab

Actual Results:
see screenshot

Expected Results:
good highlight


Reproducible: Always


User Profile Reset: No

Additional Info:
all macos, LibO 24.2
Comment 1 Dennis Roczek 2024-03-04 12:03:20 UTC
Created attachment 192943 [details]
Optical glitch
Comment 2 Dennis Roczek 2024-03-04 12:04:41 UTC
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 4; OS: macOS 11.7.10; UI render: Skia/Raster; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded
Comment 3 Dennis Roczek 2024-03-04 13:54:46 UTC
(In reply to Dennis Roczek from comment #0)
> Description:
> see screenshot: the highlighting of the tabs in the field menu is a bit
> moved and not correctly around the tab.
> 
> Steps to Reproduce:
> Choose Insert - Field - More Fields - Functions tab
to add:
visible glitch does not happen on the first tab ("Document"), but all other tabs.
Comment 4 steve 2024-03-04 14:04:30 UTC
Created attachment 192944 [details]
Screenshot 2024-03-04 no repro intel, us

no repro Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: macOS 13.6.4; UI render: Skia/Metal; VCL: osx
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded

Apple Silicon only, maybe only other locales than US?
Comment 5 Dennis Roczek 2024-03-04 14:26:36 UTC
mmmh,

no repro with 
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 8; OS: Mac OS X 14.3.1; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

(both intel macs)

will check the next mac +  bibisecting at the moment.
Comment 6 Dennis Roczek 2024-03-04 15:18:58 UTC
even no repro with
Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 4; OS: macOS 14.3.1; UI render: Skia/Raster; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

(also intel)

still try to find if there is a good/bad commit by bibisecting, but have to clone many repros.

----

I fear that this has to do something with this really ancient
MacBook Pro (Retina, 13', Mitte 2014)
2,6 GHz Dual-Core Intel Core i5
Intel Iris 1536 MB
(no newer macos than 11.7 possible(!)
Comment 7 Dennis Roczek 2024-03-04 15:22:32 UTC
> I fear that this has to do something with this really ancient
> MacBook Pro (Retina, 13', Mitte 2014)
> 2,6 GHz Dual-Core Intel Core i5
> Intel Iris 1536 MB
> (no newer macos than 11.7 possible(!)
using Standard renderer (so turn of Skia) still repro. :-(

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 4; OS: macOS 11.7.10; UI render: default; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded
Comment 8 Dennis Roczek 2024-03-04 16:46:17 UTC
[abe61bafddf2195659d32c0ea2ce94d89f7ce377] source c5396467030ebb47d3d0d649b28aed2cf2554a66


first bad commit 

https://git.libreoffice.org/core/+/c5396467030ebb47d3d0d649b28aed2cf2554a66

commit c5396467030ebb47d3d0d649b28aed2cf2554a66	[log]
author	Caolán McNamara <caolanm@redhat.com>	Thu Nov 03 15:17:49 2022 +0000
committer	Caolán McNamara <caolanm@redhat.com>	Tue Nov 22 12:12:01 2022 +0100
tree 4339d058dafa1d35d8689143fcda203e9a5e6595
parent aa0c9eb6bd91126eebe1eb2444b024572b740a6a [diff]

use an alternative macOS themeing approach to support dark-mode

checkboxes, radiobuttons and pushbuttons look decent, focus ring works

editboxes work, focus ring doesn't for some reason, so faked that in

spinbuttons work

list and combo boxes work

scrollbars work, though with some degree of overly complicated fakery

tabpanes and tabcontrols work

sliders work

progress bars work

disclosure butttons in listtrees work

a dark mode icon theme is automatically selected under dark mode

Change-Id: I4835c7639f725a0154288440fcad400f618438e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141435
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>



cc: caolan


I'm still not sure if it is the hardware of this specific old MBP, couldn't reproduce it on two newer macs. I have one older (but a bit newer one) which is hanging on macos12.7 (no newer upgrades possible).

This is low prio as I'm guessing that this is only a matter of time ;-)
Comment 9 Dennis Roczek 2024-03-04 16:46:31 UTC
setting to new.
Comment 10 Caolán McNamara 2024-03-04 20:17:54 UTC
presumably this is from the call to "paintFocusRect" in the "case ControlType::TabItem:" of vcl/osx/salnativewidgets.cxx

does the same problem happen for the first and last tabs too or just the ones in the middle (the code treats the first and last different from the others)

And only known to happen (so far) with 11.7 ?

Maybe, if we knew what adjustment there would work, it would be possible to put some version specific bodge in there for certain older versions.
Comment 11 Dennis Roczek 2024-03-05 08:37:36 UTC
(In reply to Caolán McNamara from comment #10)
> does the same problem happen for the first and last tabs too or just the
> ones in the middle (the code treats the first and last different from the
> others)

The first tab is ok, the last one is having the same glitch.



> And only known to happen (so far) with 11.7 ?

no repro with
Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 4; OS: macOS 12.7.3; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

So until now: yes, only 11.7


> Maybe, if we knew what adjustment there would work, it would be possible to
> put some version specific bodge in there for certain older versions.
I'm not sure: if it is really only macos11.7, I would say do not invest much time as this OS is EOL and rarely used.