Bug 160069 - Second click on Clone Formatting creates strange text formatting
Summary: Second click on Clone Formatting creates strange text formatting
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium normal
Assignee: Oliver Specht (CIB)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Clone-Formatting
  Show dependency treegraph
 
Reported: 2024-03-06 17:09 UTC by Gabor Kelemen (allotropia)
Modified: 2024-07-17 05:20 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
The example document after the second format cloning (64.47 KB, image/png)
2024-03-06 17:09 UTC, Gabor Kelemen (allotropia)
Details
Reproducible_Bug 160069 (99.63 KB, image/png)
2024-03-07 01:39 UTC, DuyN
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-03-06 17:09:34 UTC
Created attachment 193000 [details]
The example document after the second format cloning

Clicking the Clone Formatting tool a second time applies a strangely formatted font style: 15pt font size and Liberation Sans font, black color, left aligned formatting.

1. Open attachment 192963 [details]
2. Click in the "Soll A1" paragraph
3. Click the Clone Formatting tool
4. Click on one of the other paragraphs. The formatting is applied and the highlight moves from the paragraph to the textbox.
5. Click the Clone Formatting tool again.
6. Click another, not left aligned paragraph
-> it becomes formatted with: 15pt font size and Liberation Sans font, black color, left aligned formatting.

However it makes no sense to have this, if the highlight is on the textbox, then there is no text formatting highlighted that can be copied.

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

This works like this since about 3.5, before that all paragraphs got the same strange formatting - so not a recent regression.
Comment 1 DuyN 2024-03-07 01:35:30 UTC
Thank you for reporting the bug. I can confirm that the bug is present in:

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 2 DuyN 2024-03-07 01:39:37 UTC
Created attachment 193010 [details]
Reproducible_Bug 160069
Comment 3 Gabor Kelemen (allotropia) 2024-03-08 13:15:17 UTC
Fixed with

 Commit Notification 2024-03-07 21:49:07 CET

Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dbb05dc818afb08b3e05ac62bd92389a5cf90fa7

tdf#159726 Improve Clone formatting

It will be available in 24.8.0.


Verified in:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ff113b34dd6f54765995440cbedd27483fadb844
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: de-DE
Calc: default

Now it's not possible to click the Clone Formatting button the second time, with the selection on the textbox.