Bug 160338 - Calc freezes on "Format - Page Style - Header - Edit - Text Attribute" dialog
Summary: Calc freezes on "Format - Page Style - Header - Edit - Text Attribute" dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: Calc-Header-Footer
  Show dependency treegraph
 
Reported: 2024-03-24 12:27 UTC by Kevin Suo
Modified: 2024-04-01 02:27 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
bt (9.55 KB, text/plain)
2024-03-25 09:04 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Suo 2024-03-24 12:27:11 UTC
Steps to Reproduce:
1. New Calc, go to "Format - Page Style - Header" dialog, click the "Edit" button, click any of the three areas, then click the "Text Attribute" icon in the "Custom Headers" row.

--> Calc Freezes.
Now if I hit ESC, Calc will crash.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e83f7b7c84d5345879c5543b78ce6ad2b32dc2bc
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: en-US
Calc: threaded
Comment 1 Kevin Suo 2024-03-24 12:28:32 UTC
I am on Fedora Linux 39, Gnome 45.4.
Comment 2 m_a_riosv 2024-03-24 23:35:53 UTC
Works fine for me on Windows 11:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b38974391e8d4bf0d450abfaa86bbccbe1022995
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 3 Julien Nabet 2024-03-25 09:04:42 UTC
Created attachment 193285 [details]
bt

On pc Debian x86-64 with master sources updated today (+gtk3 rendering) I could reproduce this.

I also noticed this on console:
warn:svl.items:81961:81961:svl/source/items/itempool.cxx:386: SfxItemPool::unregisterItemSet: ItemSet was not registered (!)
warn:svl.items:81961:81961:svl/source/items/itempool.cxx:386: SfxItemPool::unregisterItemSet: ItemSet was not registered (!)
warn:svl.items:81961:81961:svl/source/items/itempool.cxx:386: SfxItemPool::unregisterItemSet: ItemSet was not registered (!)
warn:svx:81961:81961:svx/source/accessibility/AccessibleTextHelper.cxx:1354: DBG_UNHANDLED_EXCEPTION in Notify exception: com.sun.star.uno.RuntimeException message: "Text forwarder is invalid, model might be dead at /home/julien/lo/libreoffice/svx/source/accessibility/AccessibleTextHelper.cxx:269" context: ScAccessibleEditControlObject
warn:svx:81961:81961:svx/source/accessibility/AccessibleTextHelper.cxx:1354: DBG_UNHANDLED_EXCEPTION in Notify exception: com.sun.star.uno.RuntimeException message: "Text forwarder is invalid, model might be dead at /home/julien/lo/libreoffice/svx/source/accessibility/AccessibleTextHelper.cxx:269" context: ScAccessibleEditControlObject
warn:svx:81961:81961:svx/source/accessibility/AccessibleTextHelper.cxx:1354: DBG_UNHANDLED_EXCEPTION in Notify exception: com.sun.star.uno.RuntimeException message: "Text forwarder is invalid, model might be dead at /home/julien/lo/libreoffice/svx/source/accessibility/AccessibleTextHelper.cxx:269" context: ScAccessibleEditControlObject
Comment 4 Julien Nabet 2024-03-25 09:33:15 UTC
Armin: thought you might be interested in this one since it's in itempool.

BTW, my BT is from a debug build.
Comment 5 Gabor Kelemen (allotropia) 2024-03-25 19:21:01 UTC
This started to crash at:

https://git.libreoffice.org/core/+/3c3270c3527ce5bb7653727bc7749e4d58ba64cc

author	Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>	Thu Feb 15 19:14:42 2024 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	Fri Feb 16 17:05:59 2024 +0100

ITEM: Better test for DynamicDefaultItems

But it was not good before either, as the Text Attribute dialog was inactive and the dialogs opened before it were closed first by pressing Esc. This started in:

https://git.libreoffice.org/core/+/76e9023c8abc823447b1128056e55238f90da8d6

author	Noel Grandin <noelgrandin@gmail.com>	Mon Jan 22 08:36:28 2024 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	Wed Jan 24 06:58:14 2024 +0100

convert more calc dialogs to async

Looks like separate issues?

Adding CC to: Noel Grandin
Comment 6 Noel Grandin 2024-03-26 09:02:58 UTC
Fix is https://gerrit.libreoffice.org/c/core/+/165305
Comment 7 Commit Notification 2024-03-26 16:16:41 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc1b2a0ab2ecddaeead680aee80a49109082a47b

tdf#160338 Calc freeze on Text Attribute dialog

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Kevin Suo 2024-04-01 02:27:25 UTC
Verified fixed on master. Thank you for the quick fix.