Bug 160392 - Print dialog preview's measurement are black on dark background in dark mode (gtk3)
Summary: Print dialog preview's measurement are black on dark background in dark mode ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:24.8.0 target:24.2.3 target:7.6.7
Keywords: accessibility, bibisected, bisected, regression
Depends on:
Blocks: GTK3 Print-Dialog Linux-Dark-Mode
  Show dependency treegraph
 
Reported: 2024-03-27 11:16 UTC by Stéphane Guillou (stragu)
Modified: 2024-03-28 11:51 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of issue (52.12 KB, image/png)
2024-03-27 11:18 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-03-27 11:16:44 UTC
Steps:
1. Use OS's dark mode
2. Open Writer (or Calc)
3. Ctrl + P to open the Print dialog

Result: page measurements around preview are black on dark grey background.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

No repro on Windows 11.

OK in 6.3.0.4, bad in 6.4.0.3.

Bibisected with linux-64-6.4 to first bad build [6186d38e950017e0347aabbbc1438a5cdfe8037d] which points to:

commit bab77fcf8b80594fb49561254dfbaea381da8934
author	Caolán McNamara 	Tue Oct 01 10:20:29 2019 +0100
committer	Caolán McNamara 	Wed Oct 02 20:28:28 2019 +0200
weld PrintDialog
Reviewed-on: https://gerrit.libreoffice.org/80002

Caolán, can you please have a look?
Comment 1 Stéphane Guillou (stragu) 2024-03-27 11:18:08 UTC
Created attachment 193337 [details]
screenshot of issue
Comment 2 Stéphane Guillou (stragu) 2024-03-27 11:25:47 UTC
No issue for kf5 VCL plugin:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 3 Commit Notification 2024-03-27 20:40:00 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f89e03f3903474bc51ef8396eb366326cfc254c

Resolves: tdf#160392 preview's measurement are black on dark bg in dark mode

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2024-03-27 20:51:39 UTC
should be good in trunk, backport to 24.02 in gerrit
Comment 5 Commit Notification 2024-03-28 04:42:53 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d3ed3836cbec932f8a381fcb2c85787fb0f8b766

Resolves: tdf#160392 preview's measurement are black on dark bg in dark mode

It will be available in 24.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-03-28 11:51:31 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/3afff38aa196f1538b7ba3aa060f54a7f6e44f5e

Resolves: tdf#160392 preview's measurement are black on dark bg in dark mode

It will be available in 7.6.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.