Bug 160399 - Print Preview freezes with whole row merged in large spreadsheet
Summary: Print Preview freezes with whole row merged in large spreadsheet
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.3 target:24...
Keywords: needsDevAdvice, perf
Depends on:
Blocks: Calc-Merge-Split Print-Preview Calc-large-spreadsheets
  Show dependency treegraph
 
Reported: 2024-03-27 14:59 UTC by palomara
Modified: 2024-06-15 00:55 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Problem Files (12.43 KB, application/x-compressed)
2024-03-27 14:59 UTC, palomara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description palomara 2024-03-27 14:59:25 UTC
Created attachment 193352 [details]
Problem Files

The 2 files attached are created with Libre Office Calc.
If selected Print Preview they freeze the program.
I've tried them on several computers and different versions of Libre Calc,same results.
I've tried saving with different extensions also (ods, xlsx), to no avail.
Why is this?
Comment 1 Telesto 2024-03-27 21:05:26 UTC
Confirm
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0020fc1167b3760d0631001689a44427b72b816e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL threaded

and with
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4bb730be0909d9cf55b7a44d7e916aa5de16b9f7
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and with 
Version: 7.3.8.0.0+ (x64) / LibreOffice Community
Build ID: e1ad83ddb2f39419fb5d7c69eba51e2b9f49c788
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL Jumbo

-> it's slow with jumbo sheets turned ON. Fast with Jumbo Sheets turned OFF
Comment 2 m_a_riosv 2024-03-27 21:27:36 UTC
Seems the issue is with having merged the whole first row, not only a few cells.
And at the same time having active Menu/Tools/Options/LibreOffice Calc/Print — Suppress output of empty pages. And Menu/Format/Print ranges/Edit the entire sheet.

Calc try to know what are the empty pages, not data, but with the first cell in all column as part of merged range.

I think really a very corner case.
Comment 3 Telesto 2024-03-27 22:56:30 UTC
@stragu
Any idea what being advisable here. Jumbo sheets is the default since couple of releases. Should clicking row header really select every column from A1:XFD1. And clicking a column select every all rows A1:A1048576. 

Not range a typical end-user uses, IMHO. The mistake is easily made, IMHO. With serve consequences. Perf issues like here or large file size, if direct formatting being applied to a large range of cells. 

Approaches
* fix the performance issue (profile point to mdds; Multi-Dimensional Data Structure in this case)
* "blame" the end-user for using the tool wrong
* Improve UX in some way the prevent selecting large ranges unintentionally. Make it a bit harder
Comment 4 Stéphane Guillou (stragu) 2024-03-28 02:48:52 UTC
Whatever the solution, the issue has been confirmed and we don't want it to persist.
I wouldn't blame the user, I can understand why one could end up in this situation, to have some kind of "top-level heading" that looks solid for the whole width of the spreadsheet.

Let's see if developers can give an opinion, and tag a "perf" to ping anyone interested.

Repro in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 5 palomara 2024-03-28 15:31:17 UTC
The issue occured by a friend of mine. I'm her 'Helpdesk'.

The strange thing is that 'Softmaker Freeoffice' has no problem with these files.....
Comment 6 Commit Notification 2024-03-28 16:18:03 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3819e4f6f70ee60fc5c805f0d33c0062a396918c

tdf#160399 speed up print preview

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-03-28 16:45:08 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6931a596350086d52ba32bf8a84cb36fbfdb34d6

tdf#160399 speed up print preview

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Telesto 2024-03-29 22:55:08 UTC
Thanks for the patch

List of observations

A) It's loading faster now, however still a lag +/- 10 seconds
B) A single press on + or - is already slow (same 10 seconds). It freezes when using the scale slider of the print preview. 
C) The render print preview simply stops on macOS (at least) when switching tasks (goes to idle). Process continuing when LibreOffice has focus again; so you're forced to actively wait
D) Delete row 1 takes 22 seconds; but this surely a different bug based on instruments perf profile

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: aef28c23adc87b8e26eacb56c7dbcf652e907fb9
CPU threads: 8; OS: macOS 14.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 9 Commit Notification 2024-04-02 05:54:06 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e1e48bba55ff68397d514ab3771850678312f348

tdf#160399 speed up print preview

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-04-02 05:54:09 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ad14abcf790002ac6fe09afbc5a2cae46f62085

tdf#160399 speed up print preview

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-04-08 14:53:22 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/8f53eb5dc5cc7f90a2b134c5b5ad66988bcc9842

tdf#160399 speed up print preview

It will be available in 24.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2024-04-08 14:55:25 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/02b100e8ecbe47bd8d70d81dbefcb24be0501b8b

tdf#160399 speed up print preview

It will be available in 24.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Telesto 2024-04-08 19:52:57 UTC
@Stéphane Guillou
Would you mind to test this? It's still slow for me regardless all the effort put into it on Windows - similar as described in comment 8 - when using "Deelnemers en Plaatsnummers Fout" (I haven't retested it on mac)

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 748561425774fa40ab685fed80d113f7e8301158
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 14 Commit Notification 2024-06-14 08:01:02 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/f54144639568e51fb6f95e62966f664f35b90c7e

tdf#160399 speed up print preview

It will be available in 24.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Stéphane Guillou (stragu) 2024-06-15 00:55:52 UTC
(In reply to Telesto from comment #13)
> @Stéphane Guillou
> Would you mind to test this? It's still slow for me regardless all the
> effort put into it on Windows
Indeed, it is a bit quicker, but still very slow for me at Print Preview start and every scaling step inside Print Preview. About 8 seconds each with:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6f4adc1274cfac30b9097411bb193bd4386969f0
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Reopening, but thank you for already improving the situation, Noel!

(Marking 7.4 as earliest affected because that's when 16384 columns was made default.)