Bug 160625 - Breaking an imported SVG changes the objects' size
Summary: Breaking an imported SVG changes the objects' size
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
Depends on:
Blocks: regression-scaled-glyph-positions
  Show dependency treegraph
Reported: 2024-04-11 12:36 UTC by Mike Kaganski
Modified: 2024-04-11 16:09 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2024-04-11 12:36:06 UTC
Open attachment 193580 [details]. It will open in Draw, on a page roughly equal to 1x1 inch.
Select the imported object (SVG), right-click, and break.

The result is tiny objects in the top left corner, roughly 26 times smaller than original size (ratio is equal to (size of mm/100) / (size of CSS pixel)).
Comment 1 Mike Kaganski 2024-04-11 12:45:28 UTC
Regression in 7.5; was OK in 7.4.
Comment 2 Mike Kaganski 2024-04-11 12:59:03 UTC
Regression after commit 1fa731d03ba0f22cb9392a578124ea977eaab2e9 (tdf#150462 don't prescale dxarray before using DrawTextArray, 2022-08-22).
Comment 3 V Stuart Foote 2024-04-11 13:38:14 UTC
Confirmed, but how significant is breaking an SVG really, vs. the text spacing in a draw textbox object?

Version: (X86_64) / LibreOffice Community
Build ID: bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 4 Mike Kaganski 2024-04-11 14:27:02 UTC
(In reply to V Stuart Foote from comment #3)
> Confirmed, but how significant is breaking an SVG really, vs. the text
> spacing in a draw textbox object?

Not sure what is meant. If you consider any regression report as a call to revert the causing commit, then you are mistaken: most regressions are fixed by other means. Here, the likely cause is wrong handling of mapmode during metafile decomposition into Draw primitives - something that existed before the commit made use of the mapmode setting :-)
Comment 5 V Stuart Foote 2024-04-11 15:34:34 UTC
The "dancing" intra-word characters for sd text boxes (Impress or Draw) was far more annoying.

So, obviously not a suggestion to revert. 

Just confirming the impact on what is a rare action on an inserted SVG (and then really only the text spans within it, so not a high impact regression--right?).

Assumed there would be an alternative to revert.
Comment 6 Mike Kaganski 2024-04-11 16:09:55 UTC
I suspect that ImpSdrGDIMetaFileImport handles MapMode wrong. I suggest that as a possible code pointer to whoever knows enough about our metafile processing.