Bug 160670 - FILEOPEN XLSX Missing pivot tables
Summary: FILEOPEN XLSX Missing pivot tables
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+ Master
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Pivot-Table-XLSX
  Show dependency treegraph
 
Reported: 2024-04-15 12:35 UTC by Gabor Kelemen (allotropia)
Modified: 2024-04-18 08:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-04-15 12:35:31 UTC
To collect comments from other bugs: a fresh round of testing shows that after recent XLSX-pivot import patches, some pivot tables are not imported anymore.

- attachment 148009 [details] from bug 122470, current screenshot: attachment 193684 [details]
- attachment 147995 [details] from bug 122463, current screenshot: attachment 193680 [details]

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d76f1877f699c91f5e4a020641c6d65064bfb997
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default

Was good in a 6 days old bibisect-linux master:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f3d0a184c4da57907a1fcf1ed784340be7d974d6
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2024-04-15 12:36:42 UTC
Presumably after one of these:

Age	Commit message (Expand)	Author	Files	Lines
2 days	pivot: Export Pivot Table "formats" element(s)	Tomaž Vajngerl	8	-53/+184
3 days	sc: fix -Werror,-Wunused-but-set-variable	Miklos Vajna	1	-2/+0
3 days	pivot: PivotTableFormatOutput to resolve and set PT cell format	Tomaž Vajngerl	20	-105/+860
4 days	pivot: remove duplication in ScDPSaveDimension::GetMemberByName	Tomaž Vajngerl	1	-8/+8
4 days	pivot: ScDPSource prefix members	Tomaž Vajngerl	2	-150/+140
4 days	pivot: use ScPatternAttr not styles for pivot table cell format	Tomaž Vajngerl	5	-24/+22
4 days	pivot: also set format on a data field within row/column output	Tomaž Vajngerl	1	-2/+7
4 days	pivot: split ScDPOutput::Output to multiple methods	Tomaž Vajngerl	2	-113/+142
4 days	pivot: un-abbreviate vars. in ScDPOutput::Output	Tomaž Vajngerl	1	-32/+44
4 days	pivot: forward pivot table format data into the pivot table model	Tomaž Vajngerl	9	-7/+176
4 days	pivot: Import Pivot Table "formats" element(s)	Tomaž Vajngerl	8	-6/+388
Comment 2 Xisco Faulí 2024-04-16 09:00:46 UTC
> - attachment 148009 [details] from bug 122470, current screenshot:
> attachment 193684 [details]

It used to crash for me but it got fixed by 1dc92b9e9951ef118d2d823d54f9a022c2e41a27

> - attachment 147995 [details] from bug 122463, current screenshot:
> attachment 193680 [details]

it crashes for me since

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2024-04-11 16:31:32 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2024-04-12 08:21:19 +0200
commit c379168711858664baabe7fa482a4c7dd3bc7891 (patch)
tree 3e3e76c680dd7fe0b43c90131a915e29ce402547
parent 1dbe90cb078bddaf8bbd333823762744158c92bb (diff)
pivot: PivotTableFormatOutput to resolve and set PT cell format
Comment 3 Xisco Faulí 2024-04-16 09:19:27 UTC
This should be fixed by https://gerrit.libreoffice.org/c/core/+/166138
Comment 4 Gabor Kelemen (allotropia) 2024-04-17 13:01:50 UTC
In todays nightly, both files pivot tables are imported again:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0957ee9f5d379c80fca4027c187b471118d0490d
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default

Thanks Tomaz!
Comment 5 Xisco Faulí 2024-04-18 08:15:30 UTC
Unittest added for this in 3b50c9f54907c656d2ee23fddadc696ffdab1c94