Bug 160769 - LibreOffice 24.2.1 Document recovery only restores 1 document after crash
Summary: LibreOffice 24.2.1 Document recovery only restores 1 document after crash
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-22 07:03 UTC by BikeHelmet
Modified: 2024-04-22 19:19 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BikeHelmet 2024-04-22 07:03:15 UTC
Description:
LibreOffice 24.2.1+ only recovers a single document on my computer. Possible regression over the 7.6.x branch. I tend to have a lot of documents open - usually dozens. I have 128GB of RAM, so should not be an issue. When LibreOffice 7.6.x and earlier crash, they offer to reopen the documents at next start, and properly recover all of them. LibreOffice 24.2.1+ only offers to recover a single document, or sometimes two, with one being completely blank.


Steps to Reproduce:
1. Open a great many large documents.
2. Wait for LibreOffice 24.2.x to crash.
3. Be unable to recover said documents. (Except one.)
4. Uninstall and reinstall 7.6.x
5. Open a great many large documents.
6. Wait for LibreOffice 7.6.x to crash.
7. Recover all of the previously opened documents.

Actual Results:
7.6.x recovers all opened documents.
24.2.x recovers a single document.

Expected Results:
Both versions should recover all previously opened documents.


Reproducible: Always


User Profile Reset: No

Additional Info:
Had a working crash recovery feature.

I have rolled back to 7.6.x:

Version: 7.6.6.3 (X86_64) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-CA (en_CA); UI: en-GB
Calc: CL threaded
Comment 1 Mike Kaganski 2024-04-22 07:36:56 UTC
(In reply to BikeHelmet from comment #0)
> Expected Results:
> Both versions should recover all previously opened documents.

No, they only should recover *changed* documents (which have something to recover). Previously, LibreOffice confused people by suggesting them to "recover" documents that had no changes (bug 57414). That was fixed in version 24.2 (release notes at [1]).

[1] https://wiki.documentfoundation.org/ReleaseNotes/24.2#Core_/_General
Comment 2 BikeHelmet 2024-04-22 19:19:51 UTC
(In reply to Mike Kaganski from comment #1)
> (In reply to BikeHelmet from comment #0)
> > Expected Results:
> > Both versions should recover all previously opened documents.
> 
> No, they only should recover *changed* documents (which have something to
> recover). Previously, LibreOffice confused people by suggesting them to
> "recover" documents that had no changes (bug 57414). That was fixed in
> version 24.2 (release notes at [1]).
> 
> [1] https://wiki.documentfoundation.org/ReleaseNotes/24.2#Core_/_General

This likely should be left to the user, giving them the option to recover all of them or only changed ones. It is very disruptive when LibreOffice crashes with the new behaviour.

Here is a common scenario:
-An office worker is looking at inventory / spreadsheets / reports before a Zoom meeting with higher up management. They are also referencing some new policy documents, so that they can discuss how the changes are going on-the-floor, and have other documents opened from previous discussions with employees/managers. Some resumes are also open, and they are evaluating possible new hires. (Maybe they a half dozen restaurants in a 60km area for a group of owners/shareholders?) In total there are about 30-40 documents open, enough that the recently opened list will not catch them all.

The Zoom meeting starts. Things are going well for a few minutes. Then LibreOffice crashes abruptly. Upon restoring it, it does not reload all of the relevant documents, but only the changed ones. The employee has to scramble to locate and reopen things. The meeting takes almost 30 minutes longer due to having to find everything again. Everyone is annoyed.

I cannot think of a business user that would want the new behaviour. I would make it a choice in the recovery dialog. Microsoft Office uses the old behaviour, which I think most business users and power users would consider correct. Since it was confusing enough to some users to create a bug submission and patch, I suggest expanding the recovery dialog to accommodate both use cases and expected recovery behaviours. You could even collect telemetry data on that, and discover exactly how many people expect each method. I suspect that it's more balanced than you'd assume.