Bug 160899 - Candy: Enabling Master Elements results in shapes with default blue background
Summary: Candy: Enabling Master Elements results in shapes with default blue background
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: All All
: medium normal
Assignee: Laurent Balland
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Templates
  Show dependency treegraph
 
Reported: 2024-05-02 06:21 UTC by Gabor Kelemen (allotropia)
Modified: 2024-05-07 11:58 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Impress (605.86 KB, application/vnd.oasis.opendocument.presentation)
2024-05-02 06:21 UTC, Gabor Kelemen (allotropia)
Details
Filling the header - footer info in the example file (120.55 KB, image/png)
2024-05-02 06:22 UTC, Gabor Kelemen (allotropia)
Details
The master elements are disabled initially (59.37 KB, image/png)
2024-05-02 06:41 UTC, Gabor Kelemen (allotropia)
Details
The issue is visible after the master elements are enabled (63.50 KB, image/png)
2024-05-02 06:41 UTC, Gabor Kelemen (allotropia)
Details
Future Candy template (1.58 MB, application/vnd.oasis.opendocument.presentation-template)
2024-05-03 07:35 UTC, Laurent Balland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-05-02 06:21:52 UTC
Created attachment 193930 [details]
Example file from Impress

When the Candy template is used and the master elements are enabled, the corresponding textboxes have a default blue background instead of a transparent one.

1. Open attached file, or a new document from the Candy template
2. Go to the second slide on the left Slide pane (this works on the first)
2. Slide - Master Elements, check the boxes
-> At the bottom of the slide text boxes with default blue background appear

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

already looks like this in 7.2 when the Candy template was added. Other templates don't seem to have this behavior, such as the Portfolio template which also has disabled Master elements on its first master slide.
Comment 1 Gabor Kelemen (allotropia) 2024-05-02 06:22:22 UTC
Created attachment 193931 [details]
Filling the header - footer info in the example file
Comment 2 Gabor Kelemen (allotropia) 2024-05-02 06:41:13 UTC
Created attachment 193932 [details]
The master elements are disabled initially
Comment 3 Gabor Kelemen (allotropia) 2024-05-02 06:41:41 UTC
Created attachment 193933 [details]
The issue is visible after the master elements are enabled
Comment 4 Stéphane Guillou (stragu) 2024-05-02 07:29:33 UTC
Reproduced for all three elements in attachment, and only the date and footer when starting from scratch in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ce454f382d0d005dd3de021c7820be3ffa0bb582
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Laurent, I thought you'd be interested.
Comment 5 Laurent Balland 2024-05-02 11:22:28 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)
> Laurent, I thought you'd be interested.
Yes. And new version under review [1] does not yet fix this bug. It needs some more polish...

[1] https://gerrit.libreoffice.org/c/core/+/165602
Comment 6 Laurent Balland 2024-05-03 07:35:46 UTC
Created attachment 193946 [details]
Future Candy template

It should be fixed with this new Candy template which will be introduced with this change:
https://gerrit.libreoffice.org/c/core/+/165602

Please test and report improvements needed.
Comment 7 Stéphane Guillou (stragu) 2024-05-03 08:00:26 UTC
(In reply to Laurent Balland from comment #6)
> Created attachment 193946 [details]
> Future Candy template
> 
> It should be fixed with this new Candy template which will be introduced
> with this change:
> https://gerrit.libreoffice.org/c/core/+/165602
> 
> Please test and report improvements needed.
Solves it for me, thanks!
Comment 8 Laurent Balland 2024-05-03 15:03:32 UTC
(In reply to Stéphane Guillou (stragu) from comment #7)
> Solves it for me, thanks!
Shall I push the change?
Comment 9 Stéphane Guillou (stragu) 2024-05-07 06:19:43 UTC
(In reply to Laurent Balland from comment #8)
> (In reply to Stéphane Guillou (stragu) from comment #7)
> > Solves it for me, thanks!
> Shall I push the change?
I think so! I just +1'd it.
Comment 10 Commit Notification 2024-05-07 09:43:31 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/00b3bcc64fc32165d19e78b99cc6f78317824806

tdf#160712 tdf#160899 Update Candy template

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.