Bug 161093 - Chart Properties sidebar only accommodates 4 chart type previews, but the Pie category now has 6
Summary: Chart Properties sidebar only accommodates 4 chart type previews, but the Pie...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: kurt.nordback@protonmail.com
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Chart-Sidebar
  Show dependency treegraph
 
Reported: 2024-05-16 00:55 UTC by Stéphane Guillou (stragu)
Modified: 2024-06-14 13:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Chart type selection (74.12 KB, image/png)
2024-06-03 07:54 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-05-16 00:55:28 UTC
With the bar-of-pie and pie-of-pie chart types added for bug 50934 in LO 24.8, there are now 6 types of Pie charts. The Chart sidebar deck only accommodates 4 chart type previews, so either:
- the new ones are not shown if the current type is one of the 4 original types
- only the new ones are shown if the current types is one of the 2 new types

Steps:
1. Open Calc
2. Expand Sidebar
3. Insert new chart
4. In Wizard, choose a pie chart type
5. Look at Chart sidebar deck, Chart Type section

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 658a212585c56540a17c41111e6829716d4ef4e3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 kurt.nordback@protonmail.com 2024-05-31 14:28:48 UTC
I'm thinking it might be better to separate the of-pie chart types into a separate category in the UI. That would bring us back to four columns in the chart type selector, which I think would resolve this bug. It also would allow for different options for of-pie charts, specifically number of entries to be included in the right sub-chart (bug 161090).

Comments on this are welcome!
Comment 2 Stéphane Guillou (stragu) 2024-06-01 11:02:04 UTC
(In reply to kurt.nordback@protonmail.com from comment #1)
> I'm thinking it might be better to separate the of-pie chart types into a
> separate category in the UI.
Let's see what UX/Design contributors think.
Would be good to think ahead and consider where additional chart types might end up in the wizard and sidebar: https://bugs.documentfoundation.org/showdependencytree.cgi?id=159181&hide_resolved=1
(e.g. Histogram is currently being worked on, via GSoC: https://blog.documentfoundation.org/blog/2024/05/07/projects-selected-for-libreoffice-in-the-google-summer-of-code-2024/

> It also would
> allow for different options for of-pie charts, specifically number of
> entries to be included in the right sub-chart (bug 161090).
Why not, given that this is a very important factor and the chart updates as soon as the type is selected.
Comment 3 Heiko Tietze 2024-06-03 07:54:36 UTC
Created attachment 194515 [details]
Chart type selection

I'm rather concerned about the dialog than some second line.

But aren't these new types rather flavors of the existing charts and the appropriate implementation would be to add a checkbox somewhere? For example
A	10
B	15
C	20
D	 5
E	30
F	20
and you set "[x] Emphasis [$B$4;$BB5]" (with some nicer way to pick the items for the secondary pie). Or alternatively I could imagine a second column that identifies the values that go into the of-pie - but then again: I don't see this as an extra chart (MSO tends to make a huge fuss out of options; even the exploded pie chart is just one flag on/off).
Comment 4 kurt.nordback@protonmail.com 2024-06-07 15:18:41 UTC
This is an interesting idea, but I'm unsure of the details, particularly exactly how to specify the "emphasis" entries. The second approach would be cleaner, but also might mean of-pie charts would only be possible if the additional column were populated. This also wouldn't be compatible with OOXML's approach, so I'm not sure what would happen if importing a .xlsx without the extra column.
Comment 5 Heiko Tietze 2024-06-14 09:06:36 UTC
We discussed the topic in the design meeting.

Options are a) either add a second row or make the items smaller, or b) list it as an extra chart type, or c) don't treat the pie-of-pie as extra chart type but an attribute of pie (with attributes on/off, pie/bar currently).

Some prefer option a), other c).
Comment 6 kurt.nordback@protonmail.com 2024-06-14 13:25:19 UTC
A provisional fix, using approach (b), is here:
https://gerrit.libreoffice.org/c/core/+/168690