Bug 161245 - Correct All in Spelling Does Not Correct All (only up to next spelling error)
Summary: Correct All in Spelling Does Not Correct All (only up to next spelling error)
Status: RESOLVED DUPLICATE of bug 91151
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-23 22:25 UTC by larrybradley
Modified: 2024-06-20 04:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Source doc for testing proving Correct All function in Spelling Does Not Work. (207.34 KB, application/xml)
2024-05-23 22:58 UTC, larrybradley
Details
smaller sample ODT (17.40 KB, application/vnd.oasis.opendocument.text)
2024-06-08 13:18 UTC, Stéphane Guillou (stragu)
Details
Change the label "Close" to "Cancel" (108.24 KB, image/png)
2024-06-14 03:16 UTC, Shantanu
Details
Messagebox The spellcheck is complete (114.30 KB, image/png)
2024-06-17 03:25 UTC, Shantanu
Details
Test Document as Requested (207.53 KB, application/vnd.oasis.opendocument.text)
2024-06-19 23:48 UTC, larrybradley
Details
received the message "The spellcheck is complete" without any delay (114.48 KB, image/png)
2024-06-20 04:09 UTC, Shantanu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description larrybradley 2024-05-23 22:25:45 UTC
Description:
When invoking Spelling, then choosing the correct word to replace the misspelled word, then selecting "Correct All," only the current instance of the misspelled word is corrected. All other instances of the word are not corrected until next arrived at by the Spelling function. 

Steps to Reproduce:
1. Select "Spelling" in Writer.
2. Select the correct word to replace the misspelled word.
3.Select "Correct All"

Actual Results:
Only the current instance of the misspelled word is replace when clicking on "Correct All."

Expected Results:
Expect all instances of the misspelled word to be corrected when clicking on "Correct All." If I am right about this being an actual bug, it's a huge productivity killer.


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
Comment 1 larrybradley 2024-05-23 22:58:01 UTC
Created attachment 194316 [details]
Source doc for testing  proving Correct All function in Spelling Does Not Work.

See comments in original submission.
Comment 2 Shantanu 2024-06-06 03:12:25 UTC
Not Able to reproduce.

Version: 24.2.1.2 (AARCH64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 2; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-US (C.UTF-8); UI: en-US
Ubuntu package version: 4:24.2.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2024-06-08 13:18:27 UTC
Created attachment 194606 [details]
smaller sample ODT

I can reproduce the issue.

See these steps with smaller attachment:
1. Open ODT, which has one paragraph with four times "crious"
2. Tools > Spelling
3. Click "Correct all" to accept the default correction to "carious"
4. Click Close

Result: only the two first occurrences are corrected, not the last two.
So the corrections happen only up to the next different misspelling.

If you repeat the steps 1-3 and then also correct the next "Endeavur" misspelling, all occurrences of "crious" are corrected on closing the dialog.

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d

Same in OOo 3.3, so inherited.

Wondering if it could be related to or the same as bug 92545.
Comment 4 Shantanu 2024-06-09 05:45:10 UTC
Reproduced.

Version: 24.2.1.2 (AARCH64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 2; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-US (C.UTF-8); UI: en-US
Ubuntu package version: 4:24.2.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

I could not open the attachment 194316 [details] provided by larrybradley due to "Encoding error". Therefore I typed a wrong word multiple times in a para and used "correct all" option that worked as expected. 
Please ignore my Comment 2 😜
Comment 5 Stéphane Guillou (stragu) 2024-06-11 03:26:26 UTC

*** This bug has been marked as a duplicate of bug 91151 ***
Comment 6 Shantanu 2024-06-12 11:07:02 UTC
Until this bug is fixed, users should follow these steps to ensure the spellcheck process completes correctly:

1. Select the section of the document that needs spellchecking. (or do not select anything if you need to check the entire document)
2. Use Tools > Spelling (or press F7).
3. Address each misspelled word by selecting "Ignore / Ignore All" or "Correct / Correct All".
4. Ensure that the task is completed by waiting for the message box that states "The spellcheck is complete" and then clicking "OK".

Users who click "Close" before the "The spellcheck is complete" message appears are affected by this bug, as the spellcheck process does not fully complete. Users who wait for the completion message and click "OK" are not impacted.
Comment 7 Shantanu 2024-06-14 03:16:39 UTC
Created attachment 194720 [details]
Change the label "Close" to "Cancel"

Change the label "Close" to "Cancel" to provide a clearer indication to the user about potential issues. This adjustment encourages users to avoid premature termination of the process, thereby ensuring the task is completed successfully and preventing the bug from being triggered.
Comment 8 larrybradley 2024-06-16 16:17:02 UTC
(In reply to Shantanu from comment #6)
> Until this bug is fixed, users should follow these steps to ensure the
> spellcheck process completes correctly:
> 
> 1. Select the section of the document that needs spellchecking. (or do not
> select anything if you need to check the entire document)
> 2. Use Tools > Spelling (or press F7).
> 3. Address each misspelled word by selecting "Ignore / Ignore All" or
> "Correct / Correct All".
> 4. Ensure that the task is completed by waiting for the message box that
> states "The spellcheck is complete" and then clicking "OK".
> 
> Users who click "Close" before the "The spellcheck is complete" message
> appears are affected by this bug, as the spellcheck process does not fully
> complete. Users who wait for the completion message and click "OK" are not
> impacted.

I followed these instructions twice, using two words that repeated in the document. One of the words, "term'd", appears twice in my 104 page document; the other word, "Imployment," appears 47 times in my document. In each case when I clicked Correct All (change term'd to termed and Imployment to Employment) then waited ten minutes, I never saw a message box stating "The spellcheck is complete." Further, I have been using LO Writer since its inception and have never seen that message in the Spelling (F7) function. In each of the cases stated above —where one misspelled word appeared twice and one appeared 47 times in my document, after I click Correct All and waited for ten minutes, not only did I not receive the message that the spellcheck is complete, in each case only the first instance of the misspelling was corrected. In my humble opinion, this bug still exists exactly as I first described it, and the "fix" or "workaround" suggested by Shantanu, I respectfully argue does not work at all.
Comment 9 Shantanu 2024-06-17 03:25:13 UTC
Created attachment 194771 [details]
Messagebox The spellcheck is complete

I get the message "The spellcheck is complete" all the time. (as seen in the attachment)
Can you please upload a test document?
Comment 10 larrybradley 2024-06-19 23:48:47 UTC
Created attachment 194839 [details]
Test Document as Requested
Comment 11 Shantanu 2024-06-20 04:09:18 UTC
Created attachment 194841 [details]
received the message "The spellcheck is complete" without any delay

I was unable to reproduce the behavior described in comment 8 using attachment 194839 [details]. After correcting approximately one thousand words (not just two), I received the message "The spellcheck is complete" without any delay or lag.

However, the bug can be easily reproduced by following the steps mentioned in comment 3. If I click the "Close" button before seeing the completion message as shown in the attachment, LibreOffice forgets to check the remaining words marked as "Correct All."

If you do not plan to complete the task, please avoid using the "Correct All" button. This was not clearly indicated anywhere, leading to a very serious and subtle bug. I believe the "normal" importance should be elevated to "critical".
Comment 12 BogdanB 2024-06-20 04:31:09 UTC
This bug is a duplicate of bug 91151. All the conversation should continue on that bug. This bug is closed.