Bug 161260 - Calc comment boxes moved down after being filtered out + filesave
Summary: Calc comment boxes moved down after being filtered out + filesave
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.4.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Calc-Comments AutoFilter
  Show dependency treegraph
 
Reported: 2024-05-24 13:37 UTC by Roman
Modified: 2024-05-27 13:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
commentnewred_test3 (16.36 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-05-24 13:38 UTC, Roman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman 2024-05-24 13:37:22 UTC
Description:
При работе с фильтром комментарии ведут себя неестественно
Comments behave unnaturally when working with the filter


Steps to Reproduce:
1.	Открыть документ комменnewred_test3
2.	Применить фильтр только на 124 строчку
3.	Сохранить и закрыть
4.	Открыть документ комменnewred_test3
5.	Снять фильтр
6.	Видим результат небольшой, но достаточный
1. Open the document commentnewred_test3
2. Apply the filter only to the 124 line
3. Save and close
4. Open the document commentnewred_test3
5. Remove the filter
6. We see the result is small, but sufficient


Actual Results:
Теряет местоположение комментариев, после применения фильтра и сохранения документа.
It loses the location of comments after applying the filter and saving the document.

Expected Results:
The location of the comments has not changed



Reproducible: Always


User Profile Reset: Yes

Additional Info:
В оригинальной проблеме строк 235. При этом комментарии находятся от 5000 – строки и выше. 
In the original problem, there are 235 lines. In this case, the comments are from 5000 lines and above.
Comment 1 Roman 2024-05-24 13:38:07 UTC
Created attachment 194332 [details]
commentnewred_test3

commentnewred_test3
Comment 2 m_a_riosv 2024-05-24 21:51:57 UTC
Looks like a duplicate of tdf#150150
Comment 3 Roman 2024-05-27 06:25:36 UTC
(In reply to m_a_riosv from comment #2)
> Looks like a duplicate of tdf#150150

I looked at it, but it says about the comment in the filter. My problem is when using a filter, but all comments are below the filter. And they have a logical statement of fulfillment.
Я посмотрел, но у него сказано про комментарий в фильтре. Моя же проблема состоит при использовании фильтра, но все комментарии  ниже фильтра. И имеют логичную постановку выполненности.
Comment 4 Stéphane Guillou (stragu) 2024-05-27 13:03:43 UTC
(In reply to m_a_riosv from comment #2)
> Looks like a duplicate of tdf#150150
(That one is about the comment indicator being hidden by the autofilter dropdown button, different issue.)

Reproduced. After save, reload and remove filter, the connectors points to the correct cells but the comment boxes have been moved down. The lower they originally were, the further down they moved.

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 101b08fe1ec77ffe8c1a9b2b8f9f20884269a1ed
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3

In 7.4.0.3, the comments were visible in the top row when filtered out, and the connectors were straight when the filter removed. So, bad in a different way.

The current behaviour started in 7.4.4 at build [d28fb5db7c8cc12b3fe2a7966a3b982c96eecad7] in the linux-64-7.4 bibisect repo, which is 2194fdaef01f667dd4ef476504981867ad2c80e2, a cherrypick of:

commit b71303fe1b06c1711ad80e5a0269d41ccaaad8e1
author	Balazs Varga 	Mon Nov 21 11:12:15 2022 +0100
committer	Balazs Varga 	Tue Nov 22 19:13:29 2022 +0100
tdf#46444 tdf#152081 sc: hide notes in hidden rows or columns
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143024

Balázs, can you please have a look?