Bug 161322 - Selected Calc cells not highlighted when transparency for selection is disabled
Summary: Selected Calc cells not highlighted when transparency for selection is disabled
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords: accessibility
Depends on:
Blocks: 154140
  Show dependency treegraph
 
Reported: 2024-05-29 14:32 UTC by Michael Weghorn
Modified: 2024-06-06 05:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (21.43 KB, image/png)
2024-05-29 14:32 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2024-05-29 14:32:51 UTC
Created attachment 194424 [details]
Screenshot

Steps to reproduce:

1) start Calc
2) in expert configuration ("Tools" -> "Options" -> "Advanced" -> "Open Expert Configuration", set value for org.openoffice.Office.Common.DrawingLayer.TransparentSelection to false
3) select some cells in Calc

Actual result:

The selected cells are not highlighted, making it hard to determine which ones are selected (s. attached screenshot).

Expected result: The selected cells should be highlighted with black background, as it used to be in the past.

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 124a988ea99096ea5080060c0d1a801528bd7a5c
CPU threads: 32; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 1 Michael Weghorn 2024-05-29 14:34:56 UTC
This is a regression, bibisected to this commit:

commit 1f86fdd4b5428a8c7b253051cca93429dc71f894
Author: Noel Grandin
Date:   Tue Apr 23 16:10:48 2024 +0200

    tdf#160787 Calc active cell cursor has small transparent corners
    
    clearly I don't understand something about B2DPolyPolygon, revert part
    of
    
        commit 7b1405689d4246e0e37e8759f03e1962af964cec
        Author: Noel Grandin <noelgrandin@gmail.com>
        Date:   Fri Apr 19 22:56:04 2024 +0200
    reduce the number of drawing primitives we create in
    OverlaySelection
    
    Change-Id: If8f07d021543e2686a3acfc6a0d38b2ebc962de4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166543
    Reviewed-by: Noel Grandin

(It also works with the parent of the referenced 7b1405689d4246e0e37e8759f03e1962af964cec, i.e. the partly reverted commit did not fix the issue previously.)

@Noel: Could you please take a look?
Comment 2 ady 2024-05-29 15:53:14 UTC
(In reply to Michael Weghorn from comment #1)
> This is a regression, bibisected to this commit:

>     tdf#160787 Calc active cell cursor has small transparent corners

Same as tdf#160946.
Comment 3 Commit Notification 2024-06-01 08:23:59 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/302a221856809e2b046cb9fb1675bfff4d86a37d

tdf#161198 tdf#161322 fix selection overlays

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 ady 2024-06-02 14:13:36 UTC
(In reply to Commit Notification from comment #3)

> https://git.libreoffice.org/core/commit/
> 302a221856809e2b046cb9fb1675bfff4d86a37d
> 
> tdf#161198 tdf#161322 fix selection overlays

FWIW and FTR, probably this commit also solved tdf#160946.
Comment 5 Michael Weghorn 2024-06-06 05:10:04 UTC
Thanks, Noel! Fix verified with

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: c32d97c5a5d6f94713feaf7867abb1ce11cf9a14
CPU threads: 32; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded