Bug 161363 - Backward compatibility issue in Impress: not visible texts (white texts) and formatting issues
Summary: Backward compatibility issue in Impress: not visible texts (white texts) and ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.2.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2024-05-31 13:22 UTC by Yury
Modified: 2024-08-30 06:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
The presentation was created in impress 7.6.7 or earlier (40.42 KB, application/vnd.oasis.opendocument.presentation)
2024-05-31 13:23 UTC, Yury
Details
Picture 7.6.7 (203.86 KB, image/png)
2024-05-31 13:28 UTC, Yury
Details
Picture 24.2.3 (113.80 KB, image/png)
2024-05-31 13:28 UTC, Yury
Details
Sample file created with 7.6.7 (17.52 KB, application/vnd.oasis.opendocument.presentation)
2024-05-31 23:58 UTC, m_a_riosv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yury 2024-05-31 13:22:51 UTC
Description:
Hello,
i've opened my Impress presentation I've created in Impress 7.6 in the newest version 24.2.3 and it looks different, some text have different sizes/witdths, the text in tables, inserted form calc, are white and aren't visible.
I've attached one slide form the presentation and puctures from versions 7.6 and 24.2.3.
Could you please fix it and preserve compatibility between version.
It's very awful and cossty to re-edit presentation right before a talk after upgrade :( 


Steps to Reproduce:
1. Open the attached file in Impress 7.6.7
2. Open the attached file in Impress 24.2.3
3. Compare the pictures 

Actual Results:
The layaout is different, texts un the table are white in 24.2.3

Expected Results:
Same layout and colors in 7.6.7 and 24.2.3.


Reproducible: Always


User Profile Reset: No

Additional Info:
Attached file 
https://disk.yandex.ru/i/TqfMwjgM36F5Sg
Comment 1 Yury 2024-05-31 13:23:49 UTC
Created attachment 194485 [details]
The presentation was created in impress 7.6.7 or earlier
Comment 2 Yury 2024-05-31 13:28:02 UTC
Created attachment 194486 [details]
Picture 7.6.7
Comment 3 Yury 2024-05-31 13:28:37 UTC
Created attachment 194487 [details]
Picture 24.2.3
Comment 4 m_a_riosv 2024-05-31 23:48:42 UTC
Reproducible, even in Safe Mode:
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6084962f93efc005b6827edceae12d3170f17ccd
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded

On my installed versions.
First with the issue:
Version: 24.2.0.0.alpha1 (X86_64) / LibreOffice Community
Build ID: 06946980c858649160c634007e5fac9a5aa81f38
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL threaded

Las working for me:
Version: 7.6.7.2 (X86_64) / LibreOffice Community
Build ID: dd47e4b30cb7dab30588d6c79c651f218165e3c5
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL threaded

Regression and for my critical, it is not easy to know that the solution is to set a font color for the character, having it as automatic is what fails.
Comment 5 m_a_riosv 2024-05-31 23:58:10 UTC
Created attachment 194493 [details]
Sample file created with 7.6.7

On the versions with the issue, adding a table on the sample file, reproduce the issue.

But in a new file, no matters created on a version with the issue or in one old without the issue, works fine for me.
Comment 6 raal 2024-06-01 14:37:02 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-24.2.
Adding Cc: to Heiko Tietze ; Could you possibly take a look at this one?
Thanks
 c360bb4042d85a453b2cf898bf815aafb6afd4ad is the first bad commit
commit c360bb4042d85a453b2cf898bf815aafb6afd4ad
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sat Jul 15 09:22:37 2023 +0200

    source ddb483509113e469b771320fea52f1b089574021

154352: Resolves tdf#156182 - Automatic text color unreadable with darker cells | https://gerrit.libreoffice.org/c/core/+/154352
Comment 7 Heiko Tietze 2024-06-03 09:26:42 UTC
I can follow the issue with the shared document but struggle to create a minimal example (using 7.4.7 and 24.8). Please provide steps to reproduce.
Comment 8 Yury 2024-06-08 21:03:33 UTC
(In reply to Heiko Tietze from comment #7)
> I can follow the issue with the shared document but struggle to create a
> minimal example (using 7.4.7 and 24.8). Please provide steps to reproduce.

Hard to provide.
I think the initial Impress file was created with LibreOffice 7.5+, it was initially created in November 2023.
I've inserted the table from Calc. I've tried to create the new Impress file with a table from Calc today and this new file is opened correctly in Impress 24.2.3.2 .
It's hard to say now what exactly was done in November 2023. I'm sorry.
Comment 9 QA Administrators 2024-06-09 03:15:05 UTC Comment hidden (obsolete)
Comment 10 Heiko Tietze 2024-06-10 06:46:42 UTC
Lowering the importance, at least, as it affects one document only. Nothing to fix without clear STR. Back to QA... ;-)

(Ultimately the modification of automatic dark/light calculation is working well and makes a lot of sense. There might be corner cases where some processing is not done properly.)
Comment 11 Timur 2024-08-30 06:32:06 UTC
Repro 24.2 and 24.8, fixed in 25.2.

commit 74d910231c5591f5e497fc52f2a0132c8f41a271	[log]
author	Heiko Tietze <tietze.heiko@gmail.com>	Wed Aug 14 13:49:50 2024 +0200
committer	Heiko Tietze <heiko.tietze@documentfoundation.org>	Fri Aug 16 08:55:54 2024 +0200

Resolves tdf#161766 - WCAG 2.1 compliant luminance for isDark()

Alternative solution to I63b85694584cdc6213e7b904ed6402b6c2f2b422