Bug 161413 - BASIC help diagrams: bad clipping to page width
Summary: BASIC help diagrams: bad clipping to page width
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Buovjaga
URL:
Whiteboard: target:24.8.0 target:24.2.5
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-04 08:30 UTC by Mike Kaganski
Modified: 2024-06-04 18:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
A screenshot of the clipped diagram (90.55 KB, image/png)
2024-06-04 08:30 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2024-06-04 08:30:41 UTC
Created attachment 194540 [details]
A screenshot of the clipped diagram

Open a help page with a wide diagram, like
https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03090202.html?DbPAR=BASIC

The diagram in the Syntax section may be clipped, as in the attachment; it won't allow to scroll, nor does it show a hint that it's incomplete. This may confuse users, making them believe that e.g. on the mentioned "For" statement help page, the syntax ends with "Exit For" - see https://ask.libreoffice.org/t/basic-syntax-error-unexpected-symbol-end-sub/106496, which was likely driven by that.

The place of clipping depends on the browser window width; unexpectedly, when resizing it narrower, the page content gets wider, and the clipping moves to the right. It looks generally inconsistent. But that may be a different issue (although, I would expect it to be always not narrower than the widest non-wrappable element).
Comment 1 Commit Notification 2024-06-04 09:38:19 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/b256e08a31624c1c55894b4f11065c75423af30e

tdf#161413 Prevent SVGs without width from overflowing the container
Comment 2 Commit Notification 2024-06-04 17:55:43 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/help/commit/d5b7f6808b445825fc80c1f1ec9c1c970a64bf76

tdf#161413 Prevent SVGs without width from overflowing the container
Comment 3 Commit Notification 2024-06-04 17:56:46 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/1eb2e622fbd81928bc7e8b48f75332c787c01225

tdf#161413 Don't allow note icon SVGs to shrink
Comment 4 Commit Notification 2024-06-04 18:04:49 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/help/commit/1141bf7d15c24f3e053785dbbc60d8acf22cdc6f

tdf#161413 Don't allow note icon SVGs to shrink