Bug 161462 - Goal Seek should remember its settings during the current session
Summary: Goal Seek should remember its settings during the current session
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Keywords:
Depends on:
Blocks: GoalSeek Dialog-Remember-Settings
  Show dependency treegraph
 
Reported: 2024-06-07 18:41 UTC by Rafael Lima
Modified: 2024-06-18 13:34 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2024-06-07 18:41:49 UTC
When you set up the settings of the Goal Seek tool (Tools - Goal Seek), they should be remembered during the current session (until the document is closed). 

This is especially useful when you need to run the same Goal Seek operation multiple times. Currently we need to redefine the settings each time we use the Goal Seek.

Steps to reproduce:
1) Go to Tools - Goal Seek
2) Configure your settings and run the Solver
3) Now close the dialog
4) Open the dialog again (Tools - Goal Seek)
5) The settings were "forgotten" and we need to redefine them

Expected behavior
The settings should be remembered

I do not mean the settings need to be saved to the file, nor should they be remembered after the document is closed. But at least during the same session, it would be very helpful to remember these settings.
Comment 1 Stéphane Guillou (stragu) 2024-06-08 12:23:49 UTC
Makes sense to me.
Rafael, do you think the solution should be consistent with e.g. what the Sampling dialog would get in bug 160291?
Comment 2 Rafael Lima 2024-06-11 13:45:17 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> Makes sense to me.
> Rafael, do you think the solution should be consistent with e.g. what the
> Sampling dialog would get in bug 160291?

You mean being able to run the solver without closing the dialog?

If so, I think this is not as important in the Goal Seek dialog (at least I have never felt the need here), but no opposition to make it possible to run Goal Seek without closing the dialog.

Right now I'm working on the "remember settings" fix.
Comment 3 Commit Notification 2024-06-12 23:47:16 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/daedc81fa22690ce1a08b477a52360f05e4f5ed9

tdf#161462 Remember Goal Seek settings

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2024-06-13 04:46:32 UTC
(In reply to Rafael Lima from comment #2)
> You mean being able to run the solver without closing the dialog?
> 
> If so, I think this is not as important in the Goal Seek dialog (at least I
> have never felt the need here), but no opposition to make it possible to run
> Goal Seek without closing the dialog.
No problem, sounds good to prioritise remembering the settings, you have more experience with it than most :)
Comment 5 Commit Notification 2024-06-14 07:02:50 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/9895b2ef7bddb87ed597002361cde7d27a91d8de

tdf#161462 Remember Goal Seek settings

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-06-18 13:34:17 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5dfa4bda2cb023a6a2fbccd4ff63a704f958851f

tdf#118226, tdf#161462: sc: Add UItest

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.