Bug 161483 - ODF: Support angle units 'deg', 'grad' and 'rad' on import
Summary: ODF: Support angle units 'deg', 'grad' and 'rad' on import
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: ODF-1.2-Support
  Show dependency treegraph
 
Reported: 2024-06-09 15:50 UTC by Regina Henschel
Modified: 2024-09-30 21:21 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2024-06-09 15:50:57 UTC
ODF 1.1 has not specified the syntax of datatype 'angle'. Since ODF 1.2
it is specified as double with unit "deg", "grad" or "rad", or without
unit. The unit-less value is specified to be in degrees.

In all places, where LibreOffice reads angle values, it cannot read units. The cases where LibreOffice writes 1/10 of a degree values instead of degree are addressed in bug 161327. This bug report is for the cases where LibreOffice correctly writes unit-less values in degree, but is not able to read units.

A list (hopefully complete) of those cases is in bug 161327#c8.
Comment 1 Regina Henschel 2024-06-23 19:02:53 UTC
I have started work in https://gerrit.libreoffice.org/c/core/+/169360. It is not complete yet, but shows what I want to do.

The still missing cases are: StartingAngle (chart), TextRotation (charts), RotateAngle (table cell), CharRotation, TextRotateAngle (custom shape), RotateAngle (extruded custom shape), Skew (extruded custom shape).
CaptionAngle would be affected too, but its implementation is incomplete.
Comment 2 Commit Notification 2024-06-25 14:22:37 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f62c7a0f2333d1b7d179a43b3b0341dba7554a1

tdf#161483 enable LO to read ODF angle units

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Regina Henschel 2024-06-25 14:47:40 UTC
Not totally fixed, see the list in comment #1.

But I will not have much time in the next days, so I've removed me from "Assigned".
Comment 4 Commit Notification 2024-07-04 10:31:07 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e9aadbc0ed4916f31693018e65178b21559c73ef

tdf#161483 angle unit import for cell text rotation

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-07-07 17:47:29 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c8bec7d4b311723141d509cfeb74c5118661461c

tdf#161483 enable chart read text rotate angle unit

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.