Created attachment 194625 [details] Screenshot comparing vertical and horizontal layout The dialog is still too small. Especially: The 'Options' layout column in the Area section is so small: labels are cut and drop-down arrow in the field overlay the text in the field. The attachment compares horizontal and vertical dialog for 'Gradient' and 'Image'. The 'Options' layout column is nearly half of the width in vertical dialog than in horizontal dialog. Tested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 3c41e714497fdb13cdcbc4d6ba31887d4aaa4b61 CPU threads: 32; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded
The dialog is too small for Section "Split Options" in category "Text Flow" as well. The field unit is cut.
On kf5 I get some errors like these, but not identical to yours (since you're on Windows, the result will differ a bit). For instance, in "Text flow" - "Hyphenation" I get some labels cut out because there's not enough space. But in the "Area" section I don't get any issues. Tested with (built from master today) Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: dc243f0122ba656d2630e93bebfb84a2bfe4042a CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded
Reproduced as in screenshot with gen VCL plugin: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 70b3e128aef631e18e6451362c2e6315c28b857e CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Same in e.g. "Graphic Style > Area" in Impress.
Should we have separate reports for all similar tabs or can all be handled here? Because I see this in Calc's Format - Page Style - Page. There labels such as Text direction and Table alignment are cut off. I wonder what happens in translated versions.
From bug 161049 comment 8, about Calc's Format Cells dialog: The tab _box list_ is too small (at least some of the tab names are not completely readable in the current width of the box; depending on language too), not size-able (customized size of the tab-box-list should also be remembered).
Not sure if UX team has reviewed this yet, so added them in here.
Confirmed, but only when the Paragraph dialog is opened in its Style context, i.e. now with the vertical Tabs present on left edge showing 4 columns in the UI. The Paragraph dialog is sized correctly when opened directly, so still showing the horizontal Tabs and showing just 3 columns in its UI. Seems like the dialog needs to be made wider to hold the vertical Tabs. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 976567aee323afd09629b6adf13537908f43d2a8 CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded
(In reply to V Stuart Foote from comment #7) > Seems like the dialog needs to be made wider to hold the vertical Tabs. This is likely not going to fly. We need a complete new design concept. https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog
We discussed the topic in the design meeting. While alternative layouts might be possible, and needed for many dialogs if we switch to VT, some similar issues have been resolved recently by reverting the VT to HT. And in particular for paragraph style vs. paragraph formatting we should aim for a consistent layout.
*** Bug 166967 has been marked as a duplicate of this bug. ***
Seems the VT are not taken into account for the calculation of the necessary size. Caolan, do you have an advice where to look?
@Heiko, Samuel -- is there a reason the newer Vertical tab dialogs are getting set to fixed widths? Previous dialogs could all be resized as user desired. See comment 7 comment 8 E.g. compare the current 26.2 master Area -> Gradient for a Shape object to the Vertical tab implemented for Paragraph style Area -> Gradient, Previous implementations the dialogs could be resized, by user, to accept full field widths. Now with the 4 column vertical tab layout for the Area -> Gradient in a the same opening width, the color name fields are being truncated at opening width. The new vertical tabs consume space on the default size that had been used by name fields. Similar in other panels. Why the fixed width? And if fixed width dialog is necessary (for some reason), then the minimum(s) need to be set wider per dialog to hold the additional width of the vertical tabs.
I think the problem here (and in bug #161491) is in VerticalTabControl::GetOptimalSize of vcl/source/control/ivctrl.cxx That VerticalTabControl::GetOptimalSize is only getting the max width and height of the contained pages. And has not included the size of the page-selector on the left, the size of "m_xChooser". The returned size should likely be something like: Size aChooserSize(m_xChooser->get_preferred_size()); return Size(aChooserSize.Width() + aOptimalPageSize.Width(), std::max(aChooserSize.Height(), aOptimalPageSize.Height())); intead of: return aOptimalPageSize;
(In reply to Caolán McNamara from comment #13) > I think the problem here... Works like a charm.
*** Bug 161491 has been marked as a duplicate of this bug. ***
*** Bug 166468 has been marked as a duplicate of this bug. ***
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c6b9c12d6a08d2f80f4a9b5d10b1be00e3b1d454 Resolves tdf#161492 - Consider tab width for dialog size It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-25-8": https://git.libreoffice.org/core/commit/7a59dcf7c73d5236df6f2c454f5f41a8cdb214e4 Resolves tdf#161492 - Consider tab width for dialog size It will be available in 25.8.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.