Bug 161662 - UI Bullets and Numbering - Customize tab, Number dropdown box is too large
Summary: UI Bullets and Numbering - Customize tab, Number dropdown box is too large
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:25.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2024-06-19 16:20 UTC by Gabor Kelemen (allotropia)
Modified: 2024-08-03 18:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the issue (41.36 KB, image/png)
2024-06-19 16:20 UTC, Gabor Kelemen (allotropia)
Details
hack to demo where the height comes from (1.11 KB, patch)
2024-07-19 10:04 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-06-19 16:20:57 UTC
Created attachment 194835 [details]
Screenshot of the issue

On the Customize tab of the Bullets and Numbering dialog, the dropdown is too large under GTK3.

1. Open new Writer doc
2. Go to the toolbar, drop down the Bullets item, select Customize
3. Go to the Customize tab
-> Tne Number dropdown is too large under GTK3
but fine under QT5, gen.

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 567dbcf68711402736f65f4a0a47ef57549fe50f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Seems to have started in 6.2:

https://git.libreoffice.org/core/+/ea7b290a691f33caa3327bd1cb57b97a92c94dc7

author	Caolán McNamara <caolanm@redhat.com>	Tue Oct 02 12:15:24 2018 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Wed Oct 03 09:50:45 2018 +0200

weld SwSvxNumBulletTabDialog

Adding CC to: Caolán McNamara
Comment 1 Caolán McNamara 2024-06-19 16:26:32 UTC
Expand the dropdown and have a look of each row, the gtk combobox is probably sized to fit the largest row. It might be that one of the entries is very tall due to certain diagraphs or something in the fonts used to render the contents. But the secret is in the dropdown I think
Comment 2 Caolán McNamara 2024-07-19 10:04:14 UTC
Created attachment 195391 [details]
hack to demo where the height comes from

I think the height, or at least the first tall entry, is one of the Arabic formats. If I hack those out like so then the height is the same as the rest of the listboxes
Comment 3 Caolán McNamara 2024-07-19 10:34:14 UTC
I have a cunning idea that seems to work in practice: https://gerrit.libreoffice.org/c/core/+/170751
Comment 4 Commit Notification 2024-07-19 15:54:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db2a7489fa7ac758c1ab35f49fff284f460c5d4c

Resolves: tdf#161662 use some hackery to bring bullet combobox height down

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-08-03 18:27:51 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/62cc13b766610e1f359eee250df2f524e4dfb0aa

Related: tdf#161662 bring bullet combobox height down

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.