Bug 161717 - Track changes: Clicking on change in document should highlight related change in "Manage Changes" window/sidebar
Summary: Track changes: Clicking on change in document should highlight related change...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.4.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Track-Changes Manage-Changes-Dialog
  Show dependency treegraph
 
Reported: 2024-06-20 14:56 UTC by Gerry
Modified: 2024-07-25 18:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example Writer document LoDev 25.02 alpha (84.53 KB, application/vnd.oasis.opendocument.text)
2024-07-07 20:49 UTC, Gerry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry 2024-06-20 14:56:07 UTC
Description:
When working with track changes in a Writer document, it is currently not possible to identify/highlight/jump-to the related change in the "Manage Changes" window/sidebar. This makes working with documents with many tracked changes very difficult.

Problem: If you have a long document with hundreds of changes, the "Manage Changes" window/sidebar is very important to work through the changes. However, the changes in the document and the changes in the manage window are related one-way. If you click on a change in the "Manage Changes" window, the document window correctly jumps to the related change in the document. However, if you click on a change in the document window nothing happens.There is no way to relationship from the document window to the related change in "Manage Changes". However, this is essential to productively work with the list of changes in the manage changes window.

Expected behavior: If the user clicks on a change in the document, the "Manage Changes" window/sidebar should jump to the related change in the list and highlight it.

System: Ubuntu 24.04, LibreOffice 24.02.

Actual Results:
 

Expected Results:
 


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 Roman Kuznetsov 2024-06-23 20:00:40 UTC
Agree, +1

Jim, may be you will interesting?
Comment 2 Heiko Tietze 2024-06-24 12:18:00 UTC
Another +1
Comment 3 Jim Raykowski 2024-06-28 03:57:40 UTC
Here's a quick go at this one that seems to do what is asked:
https://gerrit.libreoffice.org/c/core/+/169692
Comment 4 Gerry 2024-07-06 18:50:23 UTC
(In reply to Jim Raykowski from comment #3)
> Here's a quick go at this one that seems to do what is asked:
> https://gerrit.libreoffice.org/c/core/+/169692

@Jim, thank you so much. Please let us know when it is possible to test it. Does it go automatically from gerrit to the code repository, or is there some further review process?
Comment 5 Commit Notification 2024-07-06 21:56:19 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/adad59c6f71532488b54804c09f0ecb7663b3a22

tdf#161717 Enhancement to identify click on tracked change in the

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Gerry 2024-07-07 20:49:04 UTC
Created attachment 195154 [details]
Example Writer document LoDev 25.02 alpha

(In reply to Commit Notification from comment #5)
> Jim Raykowski committed a patch related to this issue.
> It has been pushed to "master":

I did a quick test and this change is a huge usability improvement! Thank you so much!

Notes from my first quick test:
* The feature is stable
* It works flawlessly with additions, deletions, edits, moved text
* It has problems with added/deleted/resolved comments, though: The feature was able to correctly highlight some (but not all) deleted comments when I clicked on the anchor (little triangle) in the text. However, the feature never worked with added or resolved comments (clicking on the triangle does not make any change)

Please see the test file attached. As far as I figured it out, the feature does highlight only the deleted comment on page 2 (just above the line with the many aaaaaa in red text) when clicking on the triangle. For all other comment triangles, the feature does not seem to work. 

tested with:
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a74d99644626421fa8e4ba0728f876afe72f28e4
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 7 Gerry 2024-07-07 21:08:59 UTC
Another thing I noted:

When I have successfully highlighted a change in the "Manage Changes" window and I then click in any non-change-tracked text in the document, the highlight stays. This is absolutely fine, correct behavior and expected. However, when I start to add there anything in track changes, e.g. "abc", then the highlight in the "Manage Changes" gets lost and it suddenly jumps to the top of the list. This is unexpected behavior and IMHO incorrect. It would be better if the previous highlight either remains or the new change (the new "abc"-change) gets highlighted.

BTW: This wrong behavior (= that "Manage Changes" jumps to the top of the list when one added something new in track changes) was already there before the fix/enhancement. I mention it because it is related and maybe it can be fixed the same way along the enhancement.
Comment 8 Jim Raykowski 2024-07-08 19:57:41 UTC
(In reply to Gerry from comment #6)
> I did a quick test and this change is a huge usability improvement! Thank
> you so much!
You're welcome!

> Please see the test file attached. As far as I figured it out, the feature
> does highlight only the deleted comment on page 2 (just above the line with
> the many aaaaaa in red text) when clicking on the triangle. For all other
> comment triangles, the feature does not seem to work.
I repro this behavior. It seems only when there is a change made over the comment triangle area a click on the triangle works as expected. I'll see if I can make it work without needing this. 

Thanks for testing and feedback and for the test file.
Comment 9 Commit Notification 2024-07-10 15:28:12 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8afc4d10f917cfb5faadac0a1dd8856373693630

tdf#161717 Enhancement to identify click on tracked change

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Jim Raykowski 2024-07-11 21:43:17 UTC
(In reply to Gerry from comment #7)
> Another thing I noted:
> 
> When I have successfully highlighted a change in the "Manage Changes" window
> and I then click in any non-change-tracked text in the document, the
> highlight stays. This is absolutely fine, correct behavior and expected.
> However, when I start to add there anything in track changes, e.g. "abc",
> then the highlight in the "Manage Changes" gets lost and it suddenly jumps
> to the top of the list. This is unexpected behavior and IMHO incorrect. It
> would be better if the previous highlight either remains or the new change
> (the new "abc"-change) gets highlighted.
I repro this only when using gtk3 VCL plugin. Using x11, windows, or qt5 plugins behave for me as you expect.

> BTW: This wrong behavior (= that "Manage Changes" jumps to the top of the list
> when one added something new in track changes) was already there before the fix/
> enhancement. I mention it because it is related and maybe it can be fixed the
> same way along the enhancement.
Since this bug was present before the enhancement patch done here, I think it would be best to make a separate bug report.
Comment 11 Gerry 2024-07-12 11:21:40 UTC
(In reply to Commit Notification from comment #9)
> Jim Raykowski committed a patch related to this issue.
> It has been pushed to "master":

Hi Jim, thanks for the second commit, too. It works perfectly now! 

I have tested it using the test file and I am able to click on all change-tracked comments. I always get the correct entry highlighted in the "Manage Changes" window. 
Your two commits make a huge difference when working with long documents with many changes. It is a real productivity booster :-) Merci!

Tested with July12 daily build:
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 69fc5c396059603804b17b0f0cb076fff7188cba
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 12 Gerry 2024-07-12 12:07:10 UTC
(In reply to Jim Raykowski from comment #10)
> (In reply to Gerry from comment #7)

> Since this bug was present before the enhancement patch done here, I think
> it would be best to make a separate bug report.

Thank you. For this, I created the separate Bug 162018
Comment 13 Gerry 2024-07-13 09:01:05 UTC
(In reply to Jim Raykowski from comment #10)

@Jim: For the release notes for 25.2 would you be fine with the following line?

* Track Changes in Writer: Enhancement to identify a click on a tracked change in the document by highlighting the corresponding entry in the "Manage Changes" window and sidebar panel greatly. This enhancement improves the ability to manage a large number of changes in long documents. (Jim Raykowski) {{tdf|161717}}
Comment 14 Jim Raykowski 2024-07-13 23:44:43 UTC
(In reply to Gerry from comment #13)
> (In reply to Jim Raykowski from comment #10)
> 
> @Jim: For the release notes for 25.2 would you be fine with the following
> line?
> 
> * Track Changes in Writer: Enhancement to identify a click on a tracked
> change in the document by highlighting the corresponding entry in the
> "Manage Changes" window and sidebar panel greatly. This enhancement improves
> the ability to manage a large number of changes in long documents. (Jim
> Raykowski) {{tdf|161717}}

Thanks for doing the release note.

Did you mean for the line that reads:
"Manage Changes" window and sidebar panel greatly. This enhancement improves

to read:
"Manage Changes" window and sidebar panel. This enhancement greatly improves

?
Comment 15 Gerry 2024-07-14 07:22:10 UTC
(In reply to Jim Raykowski from comment #14) 
> Thanks for doing the release note.
> 
> Did you mean for the line that reads:
> "Manage Changes" window and sidebar panel greatly. This enhancement improves
> 
> to read:
> "Manage Changes" window and sidebar panel. This enhancement greatly improves
> 
> ?

Oh yes, thanks. 

It's now in the release notes for 25.2: https://wiki.documentfoundation.org/ReleaseNotes/25.2#Writer
Comment 16 Commit Notification 2024-07-24 23:47:51 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cac1b706ecf9b1b95c2ca31e029135533fd6bf83

related tdf#161717 Use a better approach to determine RedlinData

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Gerry 2024-07-25 08:14:02 UTC
(In reply to Commit Notification from comment #16)
> Jim Raykowski committed a patch related to this issue.
> It has been pushed to "master":

Thanks Jim, I tested you yesterday's patch "Use a better approach to determine RedlinData", too, and it works fine for me. I checked additions, deletions, edits, moved text, added/deleted/resolved comments. Everything works fine.

LibreOffice daily build 25 july 2024:
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c60dd66d89dab2174aa71c26c653f68908c7ba78
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 18 Jim Raykowski 2024-07-25 18:10:16 UTC
Gerry, Thanks for your terrific feedback.