Bug 161743 - Should be able to return focus from function sidebar deck to cell with Esc key
Summary: Should be able to return focus from function sidebar deck to cell with Esc key
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium minor
Assignee: Buovjaga
URL:
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Keywords:
Depends on:
Blocks: Sidebar-Functions
  Show dependency treegraph
 
Reported: 2024-06-22 15:14 UTC by Eyal Rozenberg
Modified: 2024-06-25 17:52 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2024-06-22 15:14:59 UTC
While the function sidebar deck is not a dialog, it is dialog-like enough, so that I expect, when pressing Esc while in it, that I returned to the state of it not being there, i.e. returned to keyboard focus on the current cell. ... but that doesn't happen; Esc seems to do nothing while the focus remains within the function sidebar deck.

Bikeshedding: Esc could move from one widget within the rectangle to another, and then out with another Esc - or directly out of the sidebar deck right away.
Comment 1 Regina Henschel 2024-06-22 15:33:25 UTC
The short cut is Ctrl+F6. It belongs to the accessibility short cuts.
Comment 2 Eyal Rozenberg 2024-06-22 16:19:33 UTC
(In reply to Regina Henschel from comment #1)
> The short cut is Ctrl+F6. 

I don't want to have to know about a special shortcut. Esc should work. It works in a lot of other contexts, and should work here as well. I don't mind if Ctrl+F6 does the same thing too...

> It belongs to the accessibility short cuts.

I expect to be able to back out of entering the functions sidebar deck regardless of accessibility considerations.
Comment 3 Buovjaga 2024-06-22 16:39:48 UTC
Oh, it's actually true that hitting Esc in Sidebar enough times should send focus back to document and it works like that in other decks: https://design.blog.documentfoundation.org/2017/02/16/guidelines-for-keyboard-navigation-in-the-sidebar/

"Use Escape to go back one step in the navigation, meaning from the content to the content panel title and then to the document."
Comment 4 ady 2024-06-22 16:48:09 UTC
(In reply to Eyal Rozenberg from comment #0)
> returned to keyboard focus on the current
> cell. ... but that doesn't happen; Esc seems to do nothing while the focus
> remains within the function sidebar deck.

I must be missing something here.

If I display the Sidebar Deck, for example with the "Properties" of the active cell, I can change some property (e.g. font size), and the focus will still be on the active cell; for example if I immediately press the Down_arrow key, the focus changes from the adjacent cell down one row.

The Sidebar Deck behaves not so much as a dialog window (for which indeed [ESC] exists the dialog without saving, i.e. "cancel"), but rather as a UI toolbar. This is expected, AFAIK.

Perhaps we need specific STR in order to reproduce the problem?
Comment 5 Buovjaga 2024-06-22 17:37:52 UTC
(In reply to ady from comment #4)
> (In reply to Eyal Rozenberg from comment #0)
> > returned to keyboard focus on the current
> > cell. ... but that doesn't happen; Esc seems to do nothing while the focus
> > remains within the function sidebar deck.
> 
> I must be missing something here.
> 
> If I display the Sidebar Deck, for example with the "Properties" of the
> active cell, I can change some property (e.g. font size), and the focus will
> still be on the active cell; for example if I immediately press the
> Down_arrow key, the focus changes from the adjacent cell down one row.
> 
> The Sidebar Deck behaves not so much as a dialog window (for which indeed
> [ESC] exists the dialog without saving, i.e. "cancel"), but rather as a UI
> toolbar. This is expected, AFAIK.
> 
> Perhaps we need specific STR in order to reproduce the problem?

This only affects the Functions deck - after Esc takes you to the Search field, it does not move you to the document.
Comment 6 Buovjaga 2024-06-22 19:09:56 UTC
Patch: https://gerrit.libreoffice.org/c/core/+/169352
Comment 7 Eyal Rozenberg 2024-06-22 19:42:23 UTC
(In reply to Buovjaga from comment #6)
> Patch: https://gerrit.libreoffice.org/c/core/+/169352

May need to press Esc twice when the text box is not empty, but I'm ok with that. +1 .
Comment 8 Rafael Lima 2024-06-23 21:58:17 UTC
(In reply to Eyal Rozenberg from comment #7)
> May need to press Esc twice when the text box is not empty, but I'm ok with
> that. +1 .

I'd say that having to press Esc twice here is the expected behavior when you have some text in the search box.
Comment 9 Commit Notification 2024-06-24 15:57:26 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1f26aa7f42795aed775646cbb616f5ee4e60326c

tdf#161743 Calc Sidebar Functions deck: move focus to document upon

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-06-25 06:10:15 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/3bf923428f75506e16a99805c00c1cc8eff28f40

tdf#161743 Calc Sidebar Functions deck: move focus to document upon

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.