Bug 161799 - Slides copy from Candy, Freshes, Grey Elegant, Growing Liberty and Yellow Idea templates loose their format
Summary: Slides copy from Candy, Freshes, Grey Elegant, Growing Liberty and Yellow Ide...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.8.0.0 beta1+
Hardware: All All
: medium normal
Assignee: Laurent Balland
URL:
Whiteboard: target:25.2.0 target:24.8.0.2
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Templates
  Show dependency treegraph
 
Reported: 2024-06-26 18:37 UTC by Laurent Balland
Modified: 2024-07-23 12:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Modified Candy template which fix the bug (1.58 MB, application/vnd.oasis.opendocument.presentation-template)
2024-07-19 09:45 UTC, Laurent Balland
Details
Modified Growing Liberty template which fix the bug (401.14 KB, application/vnd.oasis.opendocument.presentation-template)
2024-07-19 09:46 UTC, Laurent Balland
Details
Modified Yellow Idea template which fix the bug (48.75 KB, application/vnd.oasis.opendocument.presentation-template)
2024-07-19 09:47 UTC, Laurent Balland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Balland 2024-06-26 18:37:59 UTC
Description:
Candy template contains nice colorful objects. If some slides are copied from a presentation built with Candy template, and paste in a new empty presentation, formats "Filled Blue", "Filled Yellow" and "Filled Red" are replaced by a grey gradient filling.

Steps to Reproduce:
1. Create a new presentation with Candy template
2. Copy slide 2 (or any other slide containing an object with style "Filled Blue" or Red or Yellow or Outlined Color
3. Create a new presentation without any template
4. Paste the slide from Candy template

Actual Results:
Filling of blue, red and yellow rectangles are modified to a grey gradient

Expected Results:
All formats should be preserved


Reproducible: Always


User Profile Reset: Yes

Additional Info:
The bug is due the fact that some default formats (Filled Blue, Red, Yellow and same Outlined colors) have been modified in Candy template and restore to their default.
Comment 1 Stéphane Guillou (stragu) 2024-06-28 08:58:40 UTC
No repro in:

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Reproduced in:

Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 1b61abc4451d38984338b750d85770ec9871060a
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 70b3e128aef631e18e6451362c2e6315c28b857e
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 2 Stéphane Guillou (stragu) 2024-06-28 09:02:14 UTC
Marking as "bibisectNotNeeded" as you are aware of the cause, linked to your recent template streamlining work I assume?
Comment 3 Laurent Balland 2024-06-28 09:18:31 UTC
(In reply to Stéphane Guillou (stragu) from comment #2)
> Marking as "bibisectNotNeeded" as you are aware of the cause, linked to your
> recent template streamlining work I assume?

Yes. Work under progress: https://gerrit.libreoffice.org/c/core/+/169661

As root cause is the same for other templates, I won't duplicate this bug report.
Comment 4 Laurent Balland 2024-07-01 16:01:00 UTC
For Freshes template, same problems, more important on slide 8.
Change under review: https://gerrit.libreoffice.org/c/core/+/169768

No bug with Grey Elegant

Still Growing Liberty and Yellow Idea have same problems.
Comment 5 Commit Notification 2024-07-13 07:53:15 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/45a306ddd18a448254cce92c6b9301aabc9558a9

tdf#161799 Preserve default styles in Freshes template

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-07-15 08:44:36 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/ce56d12673538482dd2e94d0c4260967fe0a7e5d

tdf#161799 Preserve default styles in Freshes template

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Laurent Balland 2024-07-19 09:45:01 UTC
Created attachment 195387 [details]
Modified Candy template which fix the bug

This modified Candy template is the result of change https://gerrit.libreoffice.org/c/core/+/169661
Comment 8 Laurent Balland 2024-07-19 09:46:21 UTC
Created attachment 195388 [details]
Modified Growing Liberty template which fix the bug

This modified Growing Liberty template is the result of change https://gerrit.libreoffice.org/c/core/+/169843
Comment 9 Laurent Balland 2024-07-19 09:47:39 UTC
Created attachment 195389 [details]
Modified Yellow Idea template which fix the bug

This modified Yellow Idea template is the result of change https://gerrit.libreoffice.org/c/core/+/169944
Comment 10 Commit Notification 2024-07-21 16:21:07 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d9c156e70edd344ccdf7a0b57059d810ceddef01

tdf#161799 Preserve default styles in Candy template

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-07-21 20:05:32 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/bf7a2041c8a43dc39b403336aa8bca0eef8c2812

tdf#161799 Preserve default styles in Candy template

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2024-07-22 21:12:39 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c81943ae93f5faf71f9a6c359dd3c3a084c6f5e7

tdf#161799 Preserve default styles in Growing Liberty template

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2024-07-22 21:13:42 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7c5cf7578eebd37918f4ea649f6b27f72883aa49

tdf#161799 Preserve default styles in Yellow Idea

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2024-07-23 12:24:39 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/36bc58c665084fe966bf802d76f2f03b767e81ab

tdf#161799 Preserve default styles in Growing Liberty template

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2024-07-23 12:25:42 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/933b14764ba6092e7b8b7d0c933d75cd852e04fe

tdf#161799 Preserve default styles in Yellow Idea

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.