The ui tests may profit from a better infrastructure for setting environment variables. Currently there seem to be two possibilities to set environment variables needed for UI tests. But I've heard arguments against both. https://git.libreoffice.org/core/+/3c91fb758a429f51b89dfe9cea088691ced6d0c1/solenv/gbuild/UITest.mk#42 https://git.libreoffice.org/core/+/3c91fb758a429f51b89dfe9cea088691ced6d0c1/uitest/libreoffice/connection.py#95 To me those possibilities don't look ideal. Please share your opinion. Do you think the existing possibilities are fine? Or do you have in idea how this could be solved in a better way? Here's an example UITest which needs to set the GNUPGHOME environment variable. https://gerrit.libreoffice.org/c/core/+/167904 Here it's being done via solenv/gbuild/UITest.mk https://gerrit.libreoffice.org/c/core/+/167904/4/solenv/gbuild/UITest.mk And here it's being done via uitest/libreoffice/connection.py https://gerrit.libreoffice.org/c/core/+/167904/3/uitest/libreoffice/connection.py
Xisco, can you please comment on this?
Probably the best way to do this, is to implement another of our makefile functions, we need gb_UITest_add_arguments which would work the same as gb_CppunitTest_add_arguments where we have similar requirements for some unit tests. Then we could add the environment variables to the specific UITests that need them in the <module>/UITest_<module>_<foo>.mk files