Bug 161817 - Internal outline in Calc's autofill overlay is wrong when zoom is below 90%
Summary: Internal outline in Calc's autofill overlay is wrong when zoom is below 90%
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 beta1+
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:25.2.0 target:24.8.0.2
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-27 14:53 UTC by Rafael Lima
Modified: 2024-07-10 17:12 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Screenshot at 160% (OK) (11.85 KB, image/png)
2024-06-27 14:53 UTC, Rafael Lima
Details
Screenshot at 80% (Not OK) (15.61 KB, image/png)
2024-06-27 14:53 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2024-06-27 14:53:18 UTC
Created attachment 195011 [details]
Screenshot at 160% (OK)

Since LO 24.8 the AutoFill overlay is drawn with an internal white line for better contrast and an external line using the cursor color. This works fine if the zoom level is 100% or more.

However, if the zoom is below 100%, both lines end up being drawn in the same place and only the white line becomes visible.

Steps to reproduce
1) Open LO Calc and set the zoom to something above 100%
2) Select any range and notice the internal white outline and the external blue outline (which is the expected behavior)
3) Now set the zoom to 90% or less
4) Select any range and notice that the only the white outline is visible (not OK)

System info

Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: d681c57ba51b635ba7c85b21e062732110e8293f
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

I'm already working on a fix for this.
Comment 1 Rafael Lima 2024-06-27 14:53:52 UTC
Created attachment 195012 [details]
Screenshot at 80% (Not OK)
Comment 2 ady 2024-06-27 17:49:30 UTC
With:
Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: ef744cd5719335e9f98fbc0996c6bb32d072475e
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: threaded

At 76% zoom level and higher values, it looks normal (regarding the problem described in comment 0).

I can see the difference at 75% zoom level or lower. It stars showing the problem on the bottom line only. At 72% I also see the same behavior on the right line. At 70%, all sides show the same unexpected behavior.
Comment 3 Rafael Lima 2024-06-27 23:16:34 UTC
This patch fixes the issue:
https://gerrit.libreoffice.org/c/core/+/169665
Comment 4 Commit Notification 2024-07-08 19:54:04 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7383298e141dcc3df23c8c849513b7782b0785e2

tdf#161817 Fix Autofill overlay when zoom is low

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Rafael Lima 2024-07-08 20:52:41 UTC
Cherry pick for 24.8 in Gerrit.
Comment 6 Commit Notification 2024-07-10 17:12:41 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/84af307af8bebfc81d4173d4574c3b72efd4c253

tdf#161817 Fix Autofill overlay when zoom is low

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.