Created attachment 195064 [details] Screencast showing the issue When changing focus in vertical tab bars using the keyboard, the previously focused item (often) is painted incorrectly: It still shows artifacts of the focus rectangle, at least with the kf5/qt6 and gen VCL plugins. Steps to reproduce (s.a. attached screencast): 1) start LO Writer with the gen VCL plugin 2) open the Page Format dialog using Shift+Alt+P 3) click on the first tab item: "General" 4) use the arrow down key to select other tab pages Actual result: Not only the currently focused item has a (misplaced, see tdf#194470) focus rectangle, but the previously focused items have that, too. Expected result: Only the currently focused item should have a focus indicator. When moving focus to another item, the focus indicator should be removed for the item no longer having focus. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b6cdd1d7ffff87d16b3a5767ad33ac178f73cd34 CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: x11 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: CL threaded Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b6cdd1d7ffff87d16b3a5767ad33ac178f73cd34 CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: qt6 (cairo+wayland) Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: CL threaded
(In reply to Michael Weghorn from comment #0) > Actual result: > > Not only the currently focused item has a (misplaced, see tdf#194470) focus > rectangle, (...) Wrong bug number, should have been: "... (misplaced, see tdf#144981) ...".
Reproduced: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5bf58785ba2831de4efc2afe9df463b4a753ccb1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded
Also in windows, but a bit less, with: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b0b691aa32719aa0d41bc0f72480cc455bc414ec CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded similar without Skia Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b0b691aa32719aa0d41bc0f72480cc455bc414ec CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/23a5be4d6d04944dcbbb06912c434eedd3719b3b tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::HideDDIcon It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1582d803e1de1fb8863a9d8eaea959fd2ea588ec tdf#161853 vcl: Move logic into SvxIconChoiceCtrl_Impl::DrawFocusRect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c08ea5efd1a67ff63881fa830c37c1f4da24bbb8 tdf#161853 Translate rest of German comment It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/99d45ab7275af130485e52f71abaf7f72fd1239a tdf#161853 vcl: Use const ref instead of pointer It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72ef986133be94fd872ceaef57f3e0ffd7a538d8 tdf#161853 vcl: Use range-based for It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c467736fd3b08ec7ea0bd930bfd96add9f77a2d tdf#161853 vcl: Pass vector by const ref instead of pointer It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d3c82ab9255a019229ac9f3bc9429a63fc9d89a6 tdf#161853 vcl: Simplify SvxIconChoiceCtrl_Impl::CalcTextRect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3c9822d36e1f03be604491961be9f7c3981c2704 tdf#161853 vcl: Drop unused SvxIconChoiceCtrl_Impl::SetColumn It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25d1c2f7f7451e6be1b172ae1f97f3c0ad052276 tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::GetColumn It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9fb6ebd42bc5e2c416ffbc222261cc781c9cc3bc tdf#161853 vcl: Drop unused SvxIconChoiceCtrlColumnInfo It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9780e0843f5ee6165b8d8bc4c01071e7a2be9742 tdf#161853 vcl: Drop outdated icon choice control comment It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/212196344c99982aa42ec1eecb36006c9a12655f tdf#161853 vcl: Drop SvtIconChoiceCtrl::DrawEntryImage It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f9f0bf9b47a627e13477ac893bcb9436c72a49d5 tdf#161853 vcl: Drop SvtIconChoiceCtrl::GetEntryText It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01fa9762bcf761e5a1fd9eac6740e6829f21b5b1 tdf#161853 vcl: Simplify SvxIconChoiceCtrl_Impl::SetEntryTextMode It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9877ab0b5ebadf70a138db582f298bf0e5d1cd9e tdf#161853 vcl: Drop unnecessary indirection for icon choice control It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/65013d5d0d5c5348d51b037fb6719fd25ddedda4 tdf#161853 icon choice control: Drop WB_NOSELECTION It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/af9413cb4ad49c0b4854c08cc2804644220755ae tdf#161853 icon choice ctrl: Drop support for non-single selection modes It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/21661ce368a3458a51fc6fccab8defebb9b9e59c tdf#161853 Simplify SvxIconChoiceCtrl_Impl::SetCursor_Impl It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/681b69ab5de3e8aa735a150613837e7ab801939e tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectAll It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8a204bc8504a06ee4f2f1d358a54a5bad1c39f8b tdf#161853 icon choice ctrl: Drop tracking selected rects It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/150f61fb0056b9f26796e491ffe6e3094b805236 tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRange It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/35775e291d6570b29dc0120e4839c720152b5149 tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRect etc. It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e04b97acf2dc410c2e6380abdf23f9a2df792284 tdf#161853 icon choice ctrl: Drop unused WB_NOASYNCSELECTHDL It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0ec47906c488d20b4ce43a4df78bbed9ae7cd6b8 tdf#161853 icon choice ctrl: Drop unused async select handler It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d52136a8335024c32c81bbe79fef3557baf8fc45 tdf#161853 Drop SvxIconChoiceCtrl_Impl::GetSelectionCount It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d4d81421918209456c4669ef48c3f4f2afd8d97f tdf#161853 Drop SvxIconChoiceCtrl_Impl::bHighlightFramePressed It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1bffb064a0fbffebd2e33e3b6fdfdbc17b310489 tdf#161853 Drop SvxIconChoiceCtrl_Impl::MouseButtonUp It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/11169e6b29cbe7d782a6236d2a866b07b7501417 tdf#161853 icon choice ctrl: Drop WB_SMART_ARRANGE handling It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ed3c987a60dddcf3a75a15cbb5251d57a9bccdb7 tdf#161853 Drop SvxIconChoiceCtrl_Impl::bUpdateMode It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fed3e5d4ea03d12d17dd380359689e4f00c7f90e tdf#161853 Drop SvxIconViewFlags::POS_LOCKED It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0583a07e5fad562b7d404aa5d17579114c285219 tdf#161853 Drop SvxIconViewFlags::POS_MOVED It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14c88b770ad1d03897b9514b6ab0c696bf376f6b tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::SetEntryPos It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8809bbc87e83488509391052b27ad690615f65ac tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::{Set,Find}EntryPredecessor It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5b94bedf779f36f2b77b04171e7f6cc28cecbfc6 tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::InitPredecessors It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c04fd602ea58b9a373b3363441f0e5971165c1a6 tdf#161853 Drop always null SvxIconChoiceCtrl_Impl::pHead It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5db79db0f0c7c432d933433192506d234f6cd26e tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::GetPredecessorGrid It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/93516e9181d321fe2579308d95de85cefe21a05d tdf#161853 SvxIconChoiceCtrlEntry: Drop means to manually set neighbours It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4d43de52e0597076a81b8f8e5cee1afbf0b84b8b tdf#161853 Drop IconChoiceFlags::SelectingRect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4a755cf7de2d028f5c47c1d0223422d00a05e47 tdf#161853 Simplify SvxIconChoiceCtrl_Impl::RepaintSelectedEntries It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a52b152b4152db97bac70cd31dd707373c574400 tdf#144981 tdf#161853 icon choice ctrl: One selection border is enough It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.