Created attachment 195064 [details] Screencast showing the issue When changing focus in vertical tab bars using the keyboard, the previously focused item (often) is painted incorrectly: It still shows artifacts of the focus rectangle, at least with the kf5/qt6 and gen VCL plugins. Steps to reproduce (s.a. attached screencast): 1) start LO Writer with the gen VCL plugin 2) open the Page Format dialog using Shift+Alt+P 3) click on the first tab item: "General" 4) use the arrow down key to select other tab pages Actual result: Not only the currently focused item has a (misplaced, see tdf#194470) focus rectangle, but the previously focused items have that, too. Expected result: Only the currently focused item should have a focus indicator. When moving focus to another item, the focus indicator should be removed for the item no longer having focus. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b6cdd1d7ffff87d16b3a5767ad33ac178f73cd34 CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: x11 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: CL threaded Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b6cdd1d7ffff87d16b3a5767ad33ac178f73cd34 CPU threads: 32; OS: Linux 6.8; UI render: default; VCL: qt6 (cairo+wayland) Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: CL threaded
(In reply to Michael Weghorn from comment #0) > Actual result: > > Not only the currently focused item has a (misplaced, see tdf#194470) focus > rectangle, (...) Wrong bug number, should have been: "... (misplaced, see tdf#144981) ...".
Reproduced: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5bf58785ba2831de4efc2afe9df463b4a753ccb1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded
Also in windows, but a bit less, with: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b0b691aa32719aa0d41bc0f72480cc455bc414ec CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded similar without Skia Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b0b691aa32719aa0d41bc0f72480cc455bc414ec CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/23a5be4d6d04944dcbbb06912c434eedd3719b3b tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::HideDDIcon It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1582d803e1de1fb8863a9d8eaea959fd2ea588ec tdf#161853 vcl: Move logic into SvxIconChoiceCtrl_Impl::DrawFocusRect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c08ea5efd1a67ff63881fa830c37c1f4da24bbb8 tdf#161853 Translate rest of German comment It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/99d45ab7275af130485e52f71abaf7f72fd1239a tdf#161853 vcl: Use const ref instead of pointer It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72ef986133be94fd872ceaef57f3e0ffd7a538d8 tdf#161853 vcl: Use range-based for It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c467736fd3b08ec7ea0bd930bfd96add9f77a2d tdf#161853 vcl: Pass vector by const ref instead of pointer It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d3c82ab9255a019229ac9f3bc9429a63fc9d89a6 tdf#161853 vcl: Simplify SvxIconChoiceCtrl_Impl::CalcTextRect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3c9822d36e1f03be604491961be9f7c3981c2704 tdf#161853 vcl: Drop unused SvxIconChoiceCtrl_Impl::SetColumn It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25d1c2f7f7451e6be1b172ae1f97f3c0ad052276 tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::GetColumn It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9fb6ebd42bc5e2c416ffbc222261cc781c9cc3bc tdf#161853 vcl: Drop unused SvxIconChoiceCtrlColumnInfo It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9780e0843f5ee6165b8d8bc4c01071e7a2be9742 tdf#161853 vcl: Drop outdated icon choice control comment It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/212196344c99982aa42ec1eecb36006c9a12655f tdf#161853 vcl: Drop SvtIconChoiceCtrl::DrawEntryImage It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f9f0bf9b47a627e13477ac893bcb9436c72a49d5 tdf#161853 vcl: Drop SvtIconChoiceCtrl::GetEntryText It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01fa9762bcf761e5a1fd9eac6740e6829f21b5b1 tdf#161853 vcl: Simplify SvxIconChoiceCtrl_Impl::SetEntryTextMode It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9877ab0b5ebadf70a138db582f298bf0e5d1cd9e tdf#161853 vcl: Drop unnecessary indirection for icon choice control It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.