Bug 161899 - Crash when using "Delete all comments by author"
Summary: Crash when using "Delete all comments by author"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.6.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-05 06:36 UTC by gladys
Modified: 2024-07-19 21:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
attachment 193886 (12.95 KB, application/vnd.oasis.opendocument.presentation)
2024-07-05 06:38 UTC, gladys
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gladys 2024-07-05 06:36:49 UTC
Description:

in libreoffice writer,
when deleting all comments by authorin dropdown menu, the system crash.
after pressing recover selected,
-it will only show 1 and 2
open attachement 193886 from ticket: 160852, 



Steps to Reproduce:
1. Open attachment, which has various numbers of comments on each slide
2. Expand one comment
3. In comment's dropdown menu, click "Delete all comments by author"
2.
3.

Actual Results:
it crashes

Expected Results:
comment by author deleted


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL threaded
Comment 1 gladys 2024-07-05 06:38:55 UTC
Created attachment 195112 [details]
attachment 193886 [details]
Comment 2 Buovjaga 2024-07-05 07:14:33 UTC
Sorry, I asked you to create this, but I should have tested more. This crashed with a master build from 11 June, but it looks like the crash got fixed meanwhile. No crash with this version:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e142fa40fa721bf76da09c1fdc2d32705b5f74b3
CPU threads: 2; OS: Windows 11 X86_64 (10.0 build 22621); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 3 Xisco Faulí 2024-07-05 08:08:04 UTC
It looks like

author	Caolán McNamara <caolan.mcnamara@collabora.com>	2024-06-16 21:27:34 +0100
committer	Caolán McNamara <caolan.mcnamara@collabora.com>	2024-06-17 09:40:03 +0200
commit 5ab48fd9b1a65579b2a63077cd3d2192b57af2a5 (patch)
tree 4330529b3b6443b4d9821919fa75eaba21742c56
parent 25bd91293cd3ac7bf24f491e8eab254aa78d9fcb (diff)
fix crash in "delete comments by author" in impress

could be the one fixing it
Comment 4 Commit Notification 2024-07-19 21:19:57 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dea33b0863baa306c61df6fa04c0e9fb1a4ff468

tdf#161899: sd_annotation_tests: Add unittest

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.