Bug 161914 - Rename "Pen Width" to "Pen Thickness"
Summary: Rename "Pen Width" to "Pen Thickness"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: difficultyBeginner, easyHack, skillDesign
Depends on:
Blocks:
 
Reported: 2024-07-05 14:41 UTC by Tuomas Hietala
Modified: 2024-07-16 18:26 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2024-07-05 14:41:28 UTC
Description:
Recently the term "line width" was changed to "line thickness" in many UI strings. For consistency, the term "pen width" should also be changed to "pen thickness".

The easier case is here: https://translations.documentfoundation.org/translate/libo_ui-master/sdmessages/en/?checksum=8d2357c9e884c9b1

Perhaps the more problematic case is here, where it's used as a programming keyword:
https://translations.documentfoundation.org/translate/libo_ui-master/librelogosourcepythonpath/en/?checksum=1001d58e2232ffc4


Steps to Reproduce:
1. See the links above


Actual Results:
The term "pen width" is used.

Expected Results:
A more consistent term "pen thickness" is used.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Heiko Tietze 2024-07-12 05:26:05 UTC
The mentioned label needs to be changed in sd/uiconfig/simpress/ui/slidecontextmenu.ui. I also find the term in officecfg/registry/schema/org/openoffice/Office/Impress.xcs, not sure if we need to change it there too.
Comment 2 BogdanB 2024-07-13 13:52:59 UTC Comment hidden (obsolete)
Comment 3 BogdanB 2024-07-14 05:12:43 UTC
This is the link for the first occurence.
https://gerrit.libreoffice.org/c/core/+/170362
Comment 4 Commit Notification 2024-07-15 00:42:18 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bbd5079c58e352ece8f10328f8dcda9819c4cfbe

tdf#161914 Rename "Pen Width" to "Pen Thickness"

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Buovjaga 2024-07-15 07:43:06 UTC
Bogdan: can you also change it in Help? I found this:

source/text/simpress/01/06080000.xhp:113:<note id="par_id3150475">Anything you write with the pen will appear in your slides after exiting the slideshow. The properties of the pen can be changed by choosing the <emph>Pen Width</emph> or <emph>Change pen Color</emph> command in the context menu of the running slide show.</note>
Comment 6 BogdanB 2024-07-15 07:50:53 UTC
(In reply to Buovjaga from comment #5)
> Bogdan: can you also change it in Help? I found this:
> 

Ok. I will do it tonight
Comment 7 BogdanB 2024-07-15 14:28:04 UTC
(In reply to Heiko Tietze from comment #1)
> The mentioned label needs to be changed in
> sd/uiconfig/simpress/ui/slidecontextmenu.ui. I also find the term in
> officecfg/registry/schema/org/openoffice/Office/Impress.xcs, not sure if we
> need to change it there too.

I submited also the second occurence. Seems to be related because of this mention: <!-- UIHints: slide show context menu -->

https://gerrit.libreoffice.org/c/core/+/170482
Comment 8 BogdanB 2024-07-15 14:28:32 UTC
(In reply to Buovjaga from comment #5)
> Bogdan: can you also change it in Help? I found this:
> 
> source/text/simpress/01/06080000.xhp:113:<note id="par_id3150475">Anything
> you write with the pen will appear in your slides after exiting the
> slideshow. The properties of the pen can be changed by choosing the
> <emph>Pen Width</emph> or <emph>Change pen Color</emph> command in the
> context menu of the running slide show.</note>

In gerrit now: https://gerrit.libreoffice.org/c/help/+/170481
Comment 9 Commit Notification 2024-07-15 14:31:25 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/6dccce115b41c89de6b25b6b4fbddd0a34434115

tdf#161914 Rename "Pen Width" to "Pen Thickness"
Comment 10 Commit Notification 2024-07-15 23:54:56 UTC
Bogdan Buzea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9ee8b3b8d9b36fa0f0988db5e9ebb664f5d81da0

tdf#161914 Rename "Pen Width" to "Pen Thickness"

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.