Bug 161930 - Bundled templates must not have their mimetype file compressed to be ODF valid
Summary: Bundled templates must not have their mimetype file compressed to be ODF valid
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Templates
  Show dependency treegraph
 
Reported: 2024-07-06 15:56 UTC by Laurent Balland
Modified: 2024-11-24 15:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Balland 2024-07-06 15:56:43 UTC
Description:
When testing bundled templates with ODF validator, it complains that file 'mimetype' shall not be compressed

Steps to Reproduce:
1. Pick a bundled template such as LIBO/share/template/common/presnt/Metropolis.otp
2. Drop it on ODF validator https://odfvalidator.org/
3. Select ODF Version (1.2 extended in this case)
4. Click Validate

Actual Results:
An error is detected:
Metropolis.otp/mimetype: Error: The file 'mimetype' shall not be compressed in the ODF package 'Metropolis.otp'!

Expected Results:
No error detected


Reproducible: Always


User Profile Reset: Yes

Additional Info:
No bug with 24.2.0 beta1
Comment 1 Laurent Balland 2024-07-06 15:59:40 UTC
@Christian: you may be interested by this one, as you modified the make files that create the templates
Comment 2 Laurent Balland 2024-07-06 16:18:17 UTC
Reverting https://gerrit.libreoffice.org/c/core/+/169342 fix this bug for me.
Comment 3 Stéphane Guillou (stragu) 2024-07-22 13:26:44 UTC
Can't reproduce with my own trunk build with today's sources:

- all green for 1.2 extended conforming
- only following error for 1.2 conforming:
 Error: tag name "loext:graphic-properties" is not allowed.

Do you still see this, Laurent?
Comment 4 Laurent Balland 2024-07-23 07:56:49 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)
> Can't reproduce with my own trunk build with today's sources:
> 
> - all green for 1.2 extended conforming
> - only following error for 1.2 conforming:
>  Error: tag name "loext:graphic-properties" is not allowed.
> 
> Do you still see this, Laurent?

I can't test this week due to limited connection, but I will retest asap with fresh sources
Comment 5 QA Administrators 2024-07-24 03:14:56 UTC Comment hidden (obsolete)
Comment 6 Laurent Balland 2024-07-24 07:22:08 UTC
I do reproduce with fresh master and a 'make distclean' on my Linux.
I also tested on Windows with recent master, and I do reproduce.

I planed to fix other errors (tag name "loext:graphic-properties" is not allowed) in bundled templates. This report is only specific to Error: The file 'mimetype' shall not be compressed in the ODF package 'xxxxx.otp'!
Comment 7 Stéphane Guillou (stragu) 2024-07-25 04:36:35 UTC
(In reply to Laurent Balland from comment #6)
Hm I might be missing a build option because the file in question hasn't been changed by my builds for a while.
Comment 8 Stéphane Guillou (stragu) 2024-07-25 13:25:50 UTC
OK, after distclean and make, I can reproduce with current master.
Comment 9 zcrhonek 2024-11-15 14:07:04 UTC
(In reply to Laurent Balland from comment #2)
> Reverting https://gerrit.libreoffice.org/c/core/+/169342 fix this bug for me.

Bibisect not needed
Comment 10 Commit Notification 2024-11-24 15:34:45 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/190ccb653955fa1d23e7c0d3bf5e47769a73ba30

tdf#161930 Copy only once mimetype

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.