Description: Version: 24.2.5.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: es-DO (C.UTF-8); UI: en-US Ubuntu package version: 4:24.2.5~rc2-0ubuntu0.24.04.1~lo1 Calc: threaded Before v 24, inserting an image and setting the countour mode worked properly Now, no countour is generated for the image: the text doesn't follow the countour of the image any more. Steps to Reproduce: 1. open the attacched document 2. the image in the 1st page: verify that it has the wrap countour set but no countour is followed Actual Results: text doesn't follow the image countour Expected Results: text should follow the image countour Reproducible: Always User Profile Reset: Yes Additional Info: ok
Created attachment 195339 [details] document where the image countour doesn't work the image in the 1st page has the wrap countour setting, but no contour is followed
To test: 1. Right-click the image, and choose Wrap->Edit Contour; 2. In the dialog, click AutoContour button. This used to work in 7.6, but doesn't in 24.2.0.3, but does nothing in 24.8.0.1.
(In reply to Mike Kaganski from comment #2) > This used to work in 7.6, but doesn't in 24.2.0.3, but does nothing in > 24.8.0.1. I meant, it worked in 24.2.0.3. It regressed later.
> I meant, it worked in 24.2.0.3 So the regression is between 24.2.0.3 and 24.2.5.2
Regression after commit 1ac602f6ccd75f3b79d6c7a9d40e64677dd5741a (tdf#161498 use COL_ALPHA_OPAQUE for finding opaque pixels, 2024-06-07). But this is not tdf#161833, because it is not fixed in today's master.
(In reply to Mike Kaganski from comment #5) > Regression after commit 1ac602f6ccd75f3b79d6c7a9d40e64677dd5741a Confirmed with linux-64-24.8 bibisect repo (cherrypick bed03b80139322dc361291eed76345acc8be9e5c which is build [c061fcb6ae198147e39682df2f79e13ac2318e2f]). To see the difference, on the page 1 image: Wrap > Contour > off Wrap > Contour > on Patrick, can you please have a look?
I can reproduce this bug in my local build. Looks like the image is an 8-bit grayscale image so I'll try excluding 8-bit images from my fix for tdf#161498.
> I'll try excluding 8-bit images from my fix Actually the bug affects all images. I can confirm it with a jpg photo edited with gimp so that it has shaped contours
> Actually the bug affects all images. I can confirm it with a jpg photo edited with gimp so that it has shaped contours No, not all. Not png images with transparency > I'll try excluding 8-bit images from my fix for tdf#161498. What about limiting that fix to images with transparency?
I think I have found the cause of the problem. I have submitted a fix in the following patch but I'd lot someone else to review and/or test it on their machine before I commit it. https://gerrit.libreoffice.org/c/core/+/170627
Patrick Luby committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ee76e5041c79843ef0942c6427d4cd3717820ff6 tdf#162062 only apply fix for tdf#161833 if there is a palette It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
OK. I changed my mind and decided to commit my fix for this bug. I only have a small set of images to test with so so that @Paolo The fix should be in tomorrow's (18 July 2024) nightly master builds. Can you install tomorrow's nightly master build and see if the fix works with your documents? If the fix works, I will then submit it for inclusion in the next Libreoffice 24.2 version: https://dev-builds.libreoffice.org/daily/master/current.html Note: the nightly master builds install as LibreOfficeDev so they don't overwrite any existing LibreOffice official release that you have installed on your machine.
@Paolo Can you install tomorrow's nightly master build and see if the fix works with your documents? @Patrick Unfortunatly I cannot. I'm in a country where the internet connection is very very very slow, and it's impossible even only to think to download LO nightly build. Could you load my attacchment https://bugs.documentfoundation.org/attachment.cgi?id=195339 and see whether the countour works or not?
(In reply to Paolo Benvenuto from comment #13) > Could you load my attacchment > https://bugs.documentfoundation.org/attachment.cgi?id=195339 and see whether > the countour works or not? I already did that and the fix works for me on my Mac. I used your attached document to debug what values in the code were different in your image compared to the image in tdf#161833. I was just being cautious and hoping that you could test my fix against any other documents that are also affected by this bug. I will go ahead and submit the fix for inclusion the next version of LibreOffice 24.2 and for the upcoming LibreOffice 24.8 as well. In the meantime, can anyone else verify my fix on Windows and/or Linux?
Created attachment 195364 [details] Snapshot of attachment #195339 [details] with after fix
(In reply to Patrick Luby (volunteer) from comment #14) > In the meantime, can anyone else verify my fix on Windows and/or Linux? Fix verified on Linux with my own local build that includes your patch. Thanks Patrick!
Thank you Patrick! Will the patched be backported to 24.2?
(In reply to Paolo Benvenuto from comment #17) > Thank you Patrick! > > Will the patched be backported to 24.2? I hope so. I have submitted the following patch for LibreOffice 24.2: https://gerrit.libreoffice.org/c/core/+/170655 Since LibreOffice 24.2 is already an official release, changes require a "+1" vote from 3 developers so my patch has not been committed yet. But I am hopeful that it will get enough votes to be included in LibreOffice 24.2.6 which is scheduled to be released at the beginning of September 2024.
Patrick Luby committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/69e84cd448e359bf63ead6ed647c380b6ddc2c6c tdf#162062 only apply fix for tdf#161833 if there is a palette It will be available in 24.8.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Patrick Luby committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/796a3e836e5c2379b22e6b73aba5986f406d8c38 tdf#162062 only apply fix for tdf#161833 if there is a palette It will be available in 24.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fix confirmed with LibreOfficeDev_24.2.6.0.0