Bug 162224 - UI red dot for saving not activated after comment deleted
Summary: UI red dot for saving not activated after comment deleted
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Calc-Comments ModifiedStatus
  Show dependency treegraph
 
Reported: 2024-07-27 07:35 UTC by Manu
Modified: 2024-07-28 12:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
bug Deleted comment no Red dot for saving (46.78 KB, image/jpeg)
2024-07-27 07:35 UTC, Manu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manu 2024-07-27 07:35:33 UTC
Created attachment 195549 [details]
bug Deleted comment no Red dot for saving

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

Steps (see picture attached for results):
display a comment
select comment box, and delete
see : deleted, but file cannot be save with toolbar (no red dot)

Expected behavior: If the comment is deleted with the cell menu, then the red dot is activated. Therefore, if we delete the comment's selected box, then the red dot should be activated.
Comment 1 m_a_riosv 2024-07-27 08:14:19 UTC
Reproducible
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4be345abd678babcbb989db1e7a16021ad1da562
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 2 BogdanB 2024-07-27 12:03:59 UTC
Also with
Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 3 Telesto 2024-07-27 18:14:13 UTC
Also in
Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
Version: 5.1.0.0.alpha1+
Build ID: 49c2b9808df8a6b197dec666dfc0cda6321a4306
Threads 4; Ver: Windows 6.29; Render: GL; 

The most problematic part. The change doesn't count as modification. This means: you don't get a popup on file close, to save the file with the made modification (deletion of a comment)
Comment 4 ady 2024-07-27 18:42:42 UTC
JIC it is not completely clear:

A. Selecting the comment, entering into edit mode within the comment, deleting its content and exiting edit mode > the comment (box) has been deleted (i.e. leaving an empty comment by following these steps is not possible) > Calc recognizes that the document has changed.

B. Deleting the comment by using the cell's context menu > all works as expected.

C. Selecting the comment once (without actually entering into edit mode within the comment) and pressing [DEL], the comment disappears and the described problem is reproduced (i.e. Calc does not recognize that the document has changed).

Only case C shows the problem, since LO 3.3 (and also in AOO 4.1.15) > inherited.
Comment 5 Manu 2024-07-28 10:13:58 UTC
(In reply to ady from comment #4)
> JIC it is not completely clear: 
> Only case C shows the problem, since LO 3.3 (and also in AOO 4.1.15) >
> inherited.

I don't know who is JIC, but you are exact! the bug occurs only in case C!
Thanks for completing my words.

I thought it was enough explanatory:
"display a comment" -> cell menu, display the comment (not edit)
"select comment box, and delete" -> select the box like any picture box (not the text)
Comment 6 ady 2024-07-28 12:00:39 UTC
(In reply to Manu from comment #5)
> I don't know who is JIC,

"Just In Case..." :)