24 years ago, commit d9466e9e09f8aa618f722d9d7bef7469aa51dc14 was done to "Select the current/next/prev redline if the dialog starts". In between version 6.2 and 6.3, commit 56dd851cfc77c362c3db5c0aae4a490c7f6782cc broke this behavior for gtk3 VCL plugin (I think the because selections for the native gtk treeview do not survive a freeze). By 6.4 alpha+ the gen VCL plugin behavior only selects the dialog tree entry and not the position in the document (perhaps commit dbe5388c92d988c106cb8def839d031008a0d642 related). My question is: Should the original behavior be restore or should the behavior be as it has become to simply not have any tracked change automatically selected when the Manage Changes dialog is initially opened?
Link to a patch that restores the original behavior: https://gerrit.libreoffice.org/c/core/+/171451
Created attachment 195689 [details] video showing current and original manage changes dialog behavior on open
Heiko, any opinion?
I don't really understand what "Select the current/next/prev redline if the dialog starts" means. Probably to select the respective entry in the TC manager. This works for me but only on start (in case of multiple TC it highlights the last); the video is not clear what happens and maybe it's a gtk3 thing. If the caret goes to another TC, neither the TC manager nor the sidebar tab follows. And selecting a TC from the sidebar has no effect in a parallel open manager and vice versa. We should select the respective entry and keep track of selection changes. Version: 24.2.5.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 32; OS: Linux 6.10; UI render: default; VCL: kf6 (cairo+xcb) Locale: de-DE (en_US.UTF-8); UI: en-US 24.2.5-2 Calc: threaded
(In reply to Heiko Tietze from comment #4) > I don't really understand what "Select the current/next/prev redline if the > dialog starts" means. Probably to select the respective entry in the TC > manager. This works for me but only on start (in case of multiple TC it > highlights the last); the video is not clear what happens and maybe it's a > gtk3 thing. My understanding of "Select the current/next/prev redline if the dialog starts" is that when the Manage Changes dialog is first opened selection of the TC in the document is made relative to the document cursor (caret) position. If the cursor is on a TC then that TC is selected (highlighted in the document and in the TC manager dialog). If the cursor is previous to a TC then the next TC is selected relative to the cursor position. If the cursor is after the last TC in the document then the previous TC is selected relative to the cursor position. Not only a gtk3 thing.
(In reply to Jim Raykowski from comment #5) > If the cursor is on a TC then that TC is selected (highlighted in > the document and in the TC manager dialog). If the cursor is previous to a > TC then the next TC is selected relative to the cursor position. WFM > If the cursor is after the last TC in the document then the previous TC is selected > relative to the cursor position. The first TC is selected.
Created attachment 195884 [details] Demo showing behavior of selection on TC manger open in 4.5.0.0.alpha0+ Attached is a demo of behavior of what was highlighted in the document and TC manager on TC manager in Version: 4.5.0.0.alpha0+ The first demonstration is of the document cursor located before a change. In this case, when the TC manager is opened the next tracked change in the document is selected and the corresponding entry in the TC manager dialog list is also selected. The second demonstration is when the document cursor is on a tracked change. In this case when the TC manager is opened the tracked change that the cursor is on is selected in the document and the corresponding entry in the TC manager dialog list is also selected. The third demonstration is when the document cursor is placed after the last tracked change in the document. In this case when the TC manager is opened the last (previous) tracked change in the document is selected and the corresponding entry in the TC manager dialog list is also selected.
Auto-selection of the next/last TC in the document canvas... that was indeed a nifty thing.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7ae0542f7208573b18dadb0dee550f34ce8e41f4 resolves: tdf#162337 Initial selection of tracked change when Manage It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.