Description: In dark mode it would be preferable - to use black document background color for best contrast - slightly lighter dark grey color for the background of the surrounding area - for the comment column no background color at all may be needed Steps to Reproduce: Open Writer in dark mode and add text and comment. Actual Results: Document / canvas: R28 G28 B28 Background behind canvas: R20 G20 B20 Comment column: R102 G102 B102 Expected Results: Document / canvas: R28 G28 B28 Background behind canvas: R26 G25 B30 Comment column: N/A, no background needed? Reproducible: Always User Profile Reset: No Additional Info: Version: 25.2.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: ce0429edab26e961c73af2d4bdf1516cca05205b CPU threads: 12; OS: macOS 14.6.1; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Created attachment 195769 [details] Screenshot 2024-08-08 comparing LO main build and Apple Pages
With current GSOC work on the comment UI, would not handle this as a one-off.
(In reply to V Stuart Foote from comment #2) > With current GSOC work on the comment UI, would not handle this as a one-off. IMO this color used should be customizable via the Application Colors dialog, as various other UI colors.
(In reply to steve from comment #0) > - to use black document background color for best contrast The high contrast mode is an accessibility feature that you need to enable separately. It is definitely not suited for normal sight; in particular in dark mode overly strong contrasts are contra-productive. (In reply to V Stuart Foote from comment #2) > With current GSOC work on the comment UI, would not handle this as a one-off. => DUP *** This bug has been marked as a duplicate of bug 125217 ***
Not happy with this being set to duplicate of a bug which is about themes and customization options. The bug here was about colors used in default dark mode, not about customization. What about the light grey background color for the comment column? Is there any reason that exists? I am not sure I get what it is supposed to convey.
Comment colors are now customizable and darker by default for the dark mode.
(In reply to steve from comment #5) > What about the light grey background color for the comment column? Is there > any reason that exists? I am not sure I get what it is supposed to convey. I don't like that either... let's wait for Sahil's patches on the new LO theme system to be merged. After that, I suggest we revisit the color used behind comments (which is currently gray) and make it customizable.
Created attachment 195911 [details] 2024-08-20 status quo
So should this bug here remain new until then? I still don't believe it to be a duplicate of extending theming customization options.