Bug 162395 - when no default signing key is set, grey out option "Sign with default certificate" in save dialog
Summary: when no default signing key is set, grey out option "Sign with default certif...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on: 159040
Blocks: Digital-Signatures OpenPGP
  Show dependency tree / graph
 
Reported: 2024-08-08 13:30 UTC by steve
Modified: 2024-09-23 09:18 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
2024-09-23 LO main build OK (44.03 KB, image/png)
2024-09-23 09:18 UTC, steve 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2024-08-08 13:30:34 UTC 
Description:
https://bugs.documentfoundation.org/show_bug.cgi?id=159040 improved signing documents, but the option to "Sign with default certificate" is always available, even when no default certificate is set.

Steps to Reproduce:
Save a document without using an S/MIME cert or setting an OpenPGP key as default signing key in Preferences > LibreOffice > User Data

Actual Results:
Signing option shows in save dialog, is not greyed out and can be ticked. Ticking the option suggests to the user, that the document would be signed on save, which is misleading and untrue.

Expected Results:
When no default cert is available, grey out option to "Sign with default certificate"


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: ce0429edab26e961c73af2d4bdf1516cca05205b
CPU threads: 12; OS: macOS 14.6.1; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Buovjaga 2024-09-19 05:26:49 UTC 
I could not repro even with the commit hash mentioned in the description. macOS-only or can you still repro with the latest?

Arch Linux 64-bit
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d500848976b6244048684a9972322b582559910a
CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Built on 19 September 2024

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d500848976b6244048684a9972322b582559910a
CPU threads: 2; OS: Windows 11 X86_64 (10.0 build 22621); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-GB
Calc: threaded
Comment 2 steve 2024-09-23 09:18:24 UTC 
Created attachment 196625 [details]
2024-09-23 LO main build OK

Seems resolved (see screenshot).

With no S/MIME cert and no default OpenPGP key set in LO > Preferences > User Data, the option to `Sign with default certificate` is greyed out.


Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 854d4e6e6a98688118a71357ba1171218f6e64f3
CPU threads: 4; OS: macOS 14.7; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded