Bug 162441 - Find and Replace for Selection does ask for replacing in all active Basic modules, which is unexpected
Summary: Find and Replace for Selection does ask for replacing in all active Basic mod...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Search
  Show dependency treegraph
 
Reported: 2024-08-12 12:34 UTC by Cor Nouws
Modified: 2024-12-24 05:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2024-08-12 12:34:46 UTC
Start Basic editor
Library with multiple modules
Type and select ' foo1 foo2
Start Find and Replace..
Find: foo
Note that 'Current selection only' is checked
Click 'Replace All'
Popup appears with question:
 "Do you want to replace the text in all active modules"
--> Choosing yes, results in the text replacement on all modules, regardless of the current selection..

Version: 7.6.5.2 (X86_64) / LibreOffice Community
Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: nl-NL (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Buovjaga 2024-09-25 14:27:31 UTC
It asks, but I don't repro the replacement in all modules.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: efa381c59bf3539b5dba2249e692539056a4162e
CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Comment 2 Cor Nouws 2024-10-23 19:48:58 UTC
(In reply to Buovjaga from comment #1)
> It asks, but I don't repro the replacement in all modules.
Testing again:

 "Do you want to replace the text in all active modules"
--> Choosing no, only the current selection is handled
  > correct (apart from the question itself)

--> Choosing Yes, also text on other modules is replaced.
    Notably in my current test only 2 from 4 :)
  > not correct (apart from the question itself)

Shouldn't the easy way to solve this be: do not show the popup if 'current selection only' is chosen?
Comment 3 Buovjaga 2024-10-24 04:43:49 UTC
(In reply to Cor Nouws from comment #2)
> (In reply to Buovjaga from comment #1)
> > It asks, but I don't repro the replacement in all modules.
> Testing again:
> 
>  "Do you want to replace the text in all active modules"
> --> Choosing no, only the current selection is handled
>   > correct (apart from the question itself)
> 
> --> Choosing Yes, also text on other modules is replaced.
>     Notably in my current test only 2 from 4 :)
>   > not correct (apart from the question itself)
> 
> Shouldn't the easy way to solve this be: do not show the popup if 'current
> selection only' is chosen?

Yeah, let's do it.