Bug 162651 - Accepting cell input after AutoInput had covered the adjacent cell does not redraw the entire area (Windows, kf5/kf6, gen)
Summary: Accepting cell input after AutoInput had covered the adjacent cell does not r...
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: low trivial
Assignee: Caolán McNamara
URL:
Whiteboard: target:25.2.0 target:24.8.2
Keywords: bibisected, bisected, regression
: 163103 (view as bug list)
Depends on:
Blocks: Cell-Edit-Mode
  Show dependency treegraph
 
Reported: 2024-08-27 17:04 UTC by Buovjaga
Modified: 2024-11-29 13:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Repro screenshot for 24.8.3.2 (24.45 KB, image/png)
2024-11-29 12:54 UTC, Dan Dascalescu
Details
Repro sheet for 24.8.3.2 in Safe Mode (11.27 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-11-29 13:19 UTC, Dan Dascalescu
Details
Repro screenshot for 24.8.3.2 in Safe Mode (51.13 KB, image/png)
2024-11-29 13:20 UTC, Dan Dascalescu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2024-08-27 17:04:46 UTC
Seen while testing bug 149145.

Run a non-Gtk backend.

1. New spreadsheet in Calc
2. Enter this in A1: a very long sentence about dogs, jumping and foxes
3. Enter this in B2: don't hide me
4. Enter this in A2: a
5. Hit Backspace to cancel the AutoInput
6. Hit Enter

B2 shows only "don't". Scrolling away or similar action will cause redraw.

Bibisected with linux-64-24.8 to 6d71c21890c908225945f0fc3566255ed150f660
don't always invalidate the entire width of the calc window
Comment 1 Commit Notification 2024-08-29 07:04:50 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7ba2c87354d97448fc2b6f5ca0eea6ce0eeefb8a

Resolves: tdf#162651 area under removed editview needs to be refreshed

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Caolán McNamara 2024-08-29 07:06:56 UTC
done in trunk, backport to 24-8 in gerrit
Comment 3 Buovjaga 2024-08-29 09:35:22 UTC
Verified, thanks

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c60fdc26f1ade0c6a1f8404baf749f5dab6abd84
CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Comment 4 Commit Notification 2024-08-30 09:36:03 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/1fb18e4472161727115ac2dc0cf6e0d4818e6cb4

Resolves: tdf#162651 area under removed editview needs to be refreshed

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2024-09-23 15:34:06 UTC
*** Bug 163103 has been marked as a duplicate of this bug. ***
Comment 6 Dan Dascalescu 2024-11-29 12:11:30 UTC
Still present in 24.8.3.2.
Comment 7 BogdanB 2024-11-29 12:35:06 UTC
(In reply to Dan Dascalescu from comment #6)
> Still present in 24.8.3.2.

Have you tried in Safe Mode, or a reset to Factory Settings?
Comment 8 Dan Dascalescu 2024-11-29 12:54:12 UTC
Created attachment 197858 [details]
Repro screenshot for 24.8.3.2

Repro steps:

1. Type "foo bar baz quux optimus" in B1 (enough words to exceed the default column width)
2. Type "some long text here" in A1, so it overlaps B1
3. Press Enter

Notice that part of B1 towards the end of the cell is erased.

In the wild, I saw all words past the first one being erased.
Comment 9 Buovjaga 2024-11-29 12:56:35 UTC
(In reply to Dan Dascalescu from comment #6)
> Still present in 24.8.3.2.

Not for me with steps from comment 0. Please share your steps.

Arch Linux 64-bit
Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 480(Build:2)
CPU threads: 8; OS: Linux 6.11; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
24.8.3-1
Calc: threaded
Comment 10 Buovjaga 2024-11-29 12:58:02 UTC
(In reply to Dan Dascalescu from comment #8)
> Created attachment 197858 [details]
> Repro screenshot for 24.8.3.2
> 
> Repro steps:
> 
> 1. Type "foo bar baz quux optimus" in B1 (enough words to exceed the default
> column width)
> 2. Type "some long text here" in A1, so it overlaps B1
> 3. Press Enter
> 
> Notice that part of B1 towards the end of the cell is erased.
> 
> In the wild, I saw all words past the first one being erased.

No repro.
Comment 11 Dan Dascalescu 2024-11-29 13:08:36 UTC
I can repro with the steps from comment #8 in Safe Mode. Haven't tried Factory reset yet. I'm using the AppImage with a different Build ID from Buovjaga's.

Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 20; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 12 Dan Dascalescu 2024-11-29 13:19:18 UTC
Created attachment 197860 [details]
Repro sheet for 24.8.3.2 in Safe Mode

Here's a repro sheet showing all but the first word of column H being deleted after adding a character to column G.

1. Edit G1 and add a '#' at the end so it reads `11/09/2024 23:30:00#`
2. Press Enter

Notice column H shows only "Siargao" followed by blank space, instead of the full text "Siargao Beach Club Foam Party".
Comment 13 Dan Dascalescu 2024-11-29 13:20:41 UTC
Created attachment 197861 [details]
Repro screenshot for 24.8.3.2 in Safe Mode
Comment 14 Buovjaga 2024-11-29 13:36:15 UTC
(In reply to Dan Dascalescu from comment #12)
> Created attachment 197860 [details]
> Repro sheet for 24.8.3.2 in Safe Mode
> 
> Here's a repro sheet showing all but the first word of column H being
> deleted after adding a character to column G.
> 
> 1. Edit G1 and add a '#' at the end so it reads `11/09/2024 23:30:00#`
> 2. Press Enter
> 
> Notice column H shows only "Siargao" followed by blank space, instead of the
> full text "Siargao Beach Club Foam Party".

Indeed, this seems to be a separate case caused by commit 6d71c21890c908225945f0fc3566255ed150f660. At that commit, the result is a bit different than now, but the preceding commit does not have any redraw issue.