Created attachment 196083 [details] Screenshot with KDE/Breeze Dark theme The strong dark SQL syntax colors don't work on dark themes. Changing it at Application Colors has no effect.
Yeah... that's bad. I'll see if the strategy used for Basic themes can be applied here as well.
We have a section SQL in the app colors... but it's not effective.
(In reply to Heiko Tietze from comment #2) > We have a section SQL in the app colors... but it's not effective. Are they not? I changed the SQL colors in the App Colors dialog and it works for me. Tested with Version: 24.2.5.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 4:24.2.5-0ubuntu0.24.04.2 Calc: threaded
Changing the colors also work for me on 25.2 even with Sahil's patches applied. I'm on kf5.
Stupid me change the HTML colors ;-)
(In reply to Rafael Lima from comment #1) > I'll see if the strategy used for Basic themes can be applied here as well. Perhaps this is the better solution. I don't turn the appearance into dark currently but respond on a dark system theme. Something for you, Rafael?
(In reply to Heiko Tietze from comment #6) > (In reply to Rafael Lima from comment #1) > > I'll see if the strategy used for Basic themes can be applied here as well. > Perhaps this is the better solution. I don't turn the appearance into dark > currently but respond on a dark system theme. Something for you, Rafael? Yes, I can take care of this. I'll finish a patch I'm working, then I'll give this a try.
Created attachment 196236 [details] Screenshot showing Basic IDE and SQL editor with the same colors The proposed patch unifies the colors used in the Basic IDE and SQL editor, which IMO makes the UI more coherent. https://gerrit.libreoffice.org/c/core/+/172888 With this we can consider removing the SQL colors from the registry.