Bug 162694 - UI: Comment box in draw isn't yellow anymore, but some gradient color
Summary: UI: Comment box in draw isn't yellow anymore, but some gradient color
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: ImpressDraw-Comments
  Show dependency treegraph
 
Reported: 2024-08-29 15:24 UTC by Telesto
Modified: 2024-10-21 03:15 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (16.70 KB, image/jpeg)
2024-08-29 15:25 UTC, Telesto
Details
Screenshot previously (191.70 KB, image/png)
2024-08-30 07:30 UTC, Telesto
Details
Automatic comment colors (15.93 KB, image/png)
2024-09-03 08:23 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2024-08-29 15:24:32 UTC
Description:
UI: Comment box in draw isn't yellow anymore, but some gradient color

Steps to Reproduce:
1. Open Draw
2. Insert -> Comment
3. Click on the comment indicator

Actual Results:
See screenshot

Expected Results:
Yellow like previous (and Calc/Writer)


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c52f139b4f7140033144dde29f70a39ebedb6aa0
CPU threads: 4; OS: Windows 8.1 X86_64 (6.3 build 9600); UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: threaded
Comment 1 Telesto 2024-08-29 15:25:04 UTC
Created attachment 196099 [details]
Screenshot
Comment 2 Xisco Faulí 2024-08-29 17:02:15 UTC
Regression introduced by:

author	Heiko Tietze <heiko.tietze@documentfoundation.org>	2024-08-12 11:28:38 +0200
committer	Heiko Tietze <heiko.tietze@documentfoundation.org>	2024-08-13 11:31:54 +0200
commit afea67b1d324090db05f33a703925cb2926c008d (patch)
tree a472a60181e4db4e584b3a9b1084801aa2e880c0
parent 4b833e6b121b6ed653e19daa9d2bf0e1899f375b (diff)
Resolves tdf#162435 - TC author colors inherit anchor colors

Bisected with: bibisect-linux64-25.2
Comment 3 Heiko Tietze 2024-08-30 05:08:14 UTC
It always was a gradient to give feedback on hover / on active that turns it into a flat color. The design change has been done intentionally. Colors still depend on the author starting with beige but automatic colors change with dark settings now. And that required a few code changes which you may see.
Comment 4 Telesto 2024-08-30 07:30:19 UTC
Created attachment 196111 [details]
Screenshot previously
Comment 5 Buovjaga 2024-08-30 07:37:13 UTC
(In reply to Heiko Tietze from comment #3)
> It always was a gradient to give feedback on hover / on active that turns it
> into a flat color. The design change has been done intentionally. Colors
> still depend on the author starting with beige but automatic colors change
> with dark settings now. And that required a few code changes which you may
> see.

The point here is that your change targeted Writer comments, but also unintentionally affected Impress/Draw comments.
Comment 6 Heiko Tietze 2024-09-02 11:48:33 UTC
(In reply to Buovjaga from comment #5)
> The point here is that your change targeted Writer comments, but also
> unintentionally affected Impress/Draw comments.
We have only one comment color, previously hard-coded now customizable. It was actually a list of three colors, now only one - and the secondary colors are calculated based on luminance, IIRC. Draw/Impress has been checked and I see no issue. => NAB
Comment 7 Buovjaga 2024-09-02 11:54:29 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to Buovjaga from comment #5)
> > The point here is that your change targeted Writer comments, but also
> > unintentionally affected Impress/Draw comments.
> We have only one comment color, previously hard-coded now customizable. It
> was actually a list of three colors, now only one - and the secondary colors
> are calculated based on luminance, IIRC. Draw/Impress has been checked and I
> see no issue. => NAB

You are right that it actually was a gradient before (checked with the dropper in GIMP) - the colour change was just so slight that at a quick glance it looked uniform.

So your notabug assessment means that you don't see the gradient style change as an issue?
Comment 8 Heiko Tietze 2024-09-02 13:01:38 UTC
I didn't touch the gradient but the colors. It might have become too close to spot though. And I wouldn't disagree to replace the gradient with a more common way to indicate the hover/active state (not sure it's the same in Draw/Impress). My NAB stands because the patch is beneficial and I see no issue ("comment box is not yellow", "no gradient"). Nevertheless Telesto may have a use case that requires this exact color and gradient as before. Happy to support in this case.
Comment 9 Buovjaga 2024-09-02 13:39:31 UTC
(In reply to Heiko Tietze from comment #8)
> I didn't touch the gradient but the colors. It might have become too close
> to spot though.

No, it was too slight to spot *before*, while you changed it to a strong one.
Comment 10 Telesto 2024-09-02 19:35:53 UTC
(In reply to Heiko Tietze from comment #8)
Are simply responding based on bug title and/or bug description (with appears to be the case) or did you actually look at attachment 196099 [details]. It obvious what different compared to before. 

I'm not objecting on your commit as such .. But it appears to have so unintentional side-effect for Impress/Draw comments for whatever reason.

The comment box has a totally different color.
A) Breaks long standing history for the comment indicator (and expanded comment box) background color in Draw/Impress
B) Not matching comment(box) background color in Writer/Calc
C) Less of contrast of the comment text

The point is not about background being gradient/or not. I didn't really notice the subtitle gradient.
Comment 11 Heiko Tietze 2024-09-03 08:23:54 UTC
Created attachment 196197 [details]
Automatic comment colors

The slightly muted colors for the light theme work pretty well for me. You should give the developers and designer a bit freedom to change the application. Ultimately you can always adjust it.

Regarding the not matching colors we may ponder over a solution. The reason is that these colors are also used for inline highlighting of the comment as well as tracked changes, which use the specified color. The sidebar comment is done with increased or decreased luminance, depending on the mode. I could use the same method in Draw/Impress with the drawback of not matching colors between options and application. Using the dark colors in Writer's sidebar is a no-go.
Comment 12 Buovjaga 2024-09-03 08:28:22 UTC
(In reply to Heiko Tietze from comment #11)
> Created attachment 196197 [details]
> Automatic comment colors

It seems there is still a misunderstanding. The screenshot shows comment *indicators*, not comments.
Comment 13 Heiko Tietze 2024-09-03 08:33:39 UTC
(In reply to Buovjaga from comment #12)
> It seems there is still a misunderstanding. The screenshot shows comment
> *indicators*, not comments.

The indicator and the expanded comment use the color in sd.
(Now I see the issue with the font color for the author; and the text)