Bug 162885 - Add options to toggle whether jump to next/previous sheets cyclic in Calc file.
Summary: Add options to toggle whether jump to next/previous sheets cyclic in Calc file.
Status: RESOLVED DUPLICATE of bug 160580
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-09 12:41 UTC by Takahiro
Modified: 2024-09-09 21:12 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Takahiro 2024-09-09 12:41:04 UTC
Description:
In tdf#156311, patch https://gerrit.libreoffice.org/c/core/+/155449 makes "Cycling through tabs in Calc".

But, it is inconvenient in some situation for me.
I would like to propose that we add a option in order to switch whether moving sheets as cyclic.
Moreover, setting of the options is saved into Calc file or user profile.

Actual Results:
1. When in last sheet
2. Hit SHIFT+TAB
3. Always, Switch to first sheet

Expected Results:
A) If a new proposed option is enabled (e.g. menu item Sheet -> Navigate -> Cyclic is checked),

1. When in last sheet
2. Hit SHIFT+TAB
3. Switch to first sheet


B) If a new proposed option is disabled (e.g. menu item Sheet -> Navigate -> Cyclic is unchecked.),

1. When in last sheet
2. Hit SHIFT+TAB
3. Nothing happens

C)
The check status of the menu is remembered (savved in Calc file is better, otherwise in user profile)


Reproducible: Always


User Profile Reset: No

Additional Info:
We need add a new item, in menu or option dialog.
(I think the menu item is more convenient)

For example)
In menu: Sheet -> Navigate -> Cyclic

I tried writing a patch, and implemented an arguments to toggle cyclic in a function.
But I don't know how to add new item in menu, how to get the check state of the menu item.
Comment 1 Takahiro 2024-09-09 13:31:11 UTC
I tried to write a patch (https://gerrit.libreoffice.org/c/core/+/173078)

I implemented easily to change passing the "cyclic" flag to
ScTabView::SelectNextTab function. (This patch includes only this.)

However, I don't know how to
1) add new menu item to toggle the flag.
2) get the check state of the menu item

I tested this patch both cyclic=true and false,
by changing source codes manually and rebuild.

Can I get someone else to take over the rest of the work?
or should I complete the task myself?

(If latter, could you help me? Please give me a hint of implements)
Comment 2 m_a_riosv 2024-09-09 21:04:56 UTC
*** Bug 162882 has been marked as a duplicate of this bug. ***
Comment 3 ady 2024-09-09 21:12:59 UTC

*** This bug has been marked as a duplicate of bug 160580 ***