Bug 163699 - LO crashes when double-clicking an image in the navigator.
Summary: LO crashes when double-clicking an image in the navigator.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.2.1 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0 target:24.8.4 target:24...
Keywords: bibisected
Depends on:
Blocks:
 
Reported: 2024-10-31 09:26 UTC by Vladislav Tarakanov
Modified: 2024-11-21 08:44 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Problem file (11.40 MB, application/vnd.oasis.opendocument.text)
2024-10-31 09:29 UTC, Vladislav Tarakanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Tarakanov 2024-10-31 09:26:06 UTC
Description:
On a specific file, when double-clicking multiple times on different images in the navigator panel, LO crashes. The exact steps of creating a document that causes this behavior could not be determined, but the behavior appears after the commit https://gerrit.libreoffice.org/c/core/+/168416.

Apparently, the problem occurs when calling "GetCursor()->GetPointNode().GetTextNode()->GetTableBox()" without checking the result of "GetTextNode()" for nullptr.

Steps to Reproduce:
1. Open attached file
2. In the sidebar, open "Navigator" and expand the "Images" tab
3. Double click on any image
4. Repeat step 3 on other images until LO crashes

Actual Results:
LO Writer crashes

Expected Results:
The document scrolls to the selected image.


Reproducible: Always


User Profile Reset: No

Additional Info:
Still repro on:
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 774275231294b8b8f41024cb1d5216bbe3f23aba
CPU threads: 16; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Vladislav Tarakanov 2024-10-31 09:29:39 UTC
Created attachment 197315 [details]
Problem file

Sorry that the file is a bit large, but we couldn't reproduce it on new documents.
Comment 2 László Németh 2024-10-31 10:12:09 UTC
Proposed fix: https://gerrit.libreoffice.org/c/core/+/175865

@Vladislav Tarakanov: thanks for the bug report and code pointer!
Comment 3 Commit Notification 2024-10-31 13:27:31 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bb4da18c55dff7e6d1146fa70a83c84dea68807f

tdf#163699 sw: fix reported crash using the Navigator

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2024-11-01 17:43:43 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/5115079520192ad48ce7ce14027f5a75fc83a4cf

tdf#163699 sw: fix reported crash using the Navigator

It will be available in 24.8.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-11-05 20:25:30 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-24-8-3":

https://git.libreoffice.org/core/commit/1e89f956622b2763da1d0c6e3b90c1b54dadc3f9

tdf#163699 sw: fix reported crash using the Navigator

It will be available in 24.8.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 lebsack2 2024-11-21 08:44:49 UTC
(In reply to Commit Notification from comment #5)
> László Németh committed a patch related to this issue.
> It has been pushed to "libreoffice-24-8-3":
> 
> https://git.libreoffice.org/core/commit/
> 1e89f956622b2763da1d0c6e3b90c1b54dadc3f9
> 
> tdf#163699 sw: fix reported crash using the Navigator
> 
> It will be available in 24.8.3.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds https://blockblast2.com
> 
> Affected users are encouraged to test the fix and report feedback.

Are there any known issues or limitations with the daily builds that users should be aware of while testing the new patch for tdf#163699?