A The new chart type 'Of-Pie' is written with attribute chart:class="chart:circle". But the chart:circle type belongs to the specified types, see https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1416652_253892949. And the way it is specified has no option for a of-pie part. On the other hand, the ODF standard allows to use an own type of chart. That is done by using a value for the 'chart:class' attribute with an own namespace. <quote>Additional chart types may be supported by using a different namespace.</quote> So chart:class="loext:ofpie" would be conform to the standard. B The attributes loext:sub-bar and loext:sub-pie are written as attributes of the <chart:chart> element. I think it would be better to put this information into a <style:chart-properties> child element of a <style:style> element. That would be similar as done for a 3D variant of a chart or done for the exploded variant of a pie chart. C Two separate boolean attributes 'sub-bar' and 'sub-pie' unnecessary require priority rules. Following idea A, one attribute loext:subtype with values 'bar' and 'pie' would be enough. Not following idea A, one attribute loext:subtype with values 'bar', 'pie' and 'none' would be enough. Michael, what is your opinion on my concerns?
agree that a different chart type would be more clear, and B and C also look like improvements... i've asked Balazs and he agrees as well..
One other possibility would be to combine the concepts into two chart types, e.g.: chart:class="loext:barofpie" chart:class="loext:pieofpie" Maybe this clutters the namespace too much, but it avoids having an of-pie chart with no subtype specified, which otherwise would be allowed by the schema. Would this be better? Or do you still prefer your suggestion? I trust your judgement.
(In reply to kurt.nordback@protonmail.com from comment #2) > One other possibility would be to combine the concepts into two chart types, > e.g.: > chart:class="loext:barofpie" > chart:class="loext:pieofpie" OOXML has one type "ofPieChart", the current UI has one type. I see no enhancement in making two types. > > Maybe this clutters the namespace too much, but it avoids having an of-pie > chart with no subtype specified, which otherwise would be allowed by the > schema. If there is a chart:class="loext:ofpie", then an attribute loext:subtype would have the two possible values 'bar' and 'pie'. To make sure a subtype is always given, you could specify one of the two values as default.