Bug 164067 - UI for "Page Size" drop-down does not match in dark appearance
Summary: UI for "Page Size" drop-down does not match in dark appearance
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.3.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Windows-Dark-Mode
  Show dependency treegraph
 
Reported: 2024-11-27 09:35 UTC by ahnafr
Modified: 2024-11-28 13:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ahnafr 2024-11-27 09:35:56 UTC
Description:
Setting the appearance to Dark causes the content in the "page size" drop-down to have white text on a white body or, in other words, not be easily discernible.
It doesn't update with the change in appearance from light to dark. The text and body in the drop-down UI is correct in the light appearance.

I have not made any significant changes in the settings other than the appearance and icon sizes.

Steps to Reproduce:
1. From a clean install, assuming the appearance is set to Light, set user interface as Tabbed (View > User Interface)
2. Observe the drop-down menu (Layout > Page Size)
3. Set LibreOffice appearance to Dark (Tools > Options > LibreOffice > View)
4. Observe the drop-down menu after the change (Layout > Page Size)

Actual Results:
White background on white text in the "Page Size" drop-down

Expected Results:
Dark background on white text in the "Page Size" drop-down


Reproducible: Always


User Profile Reset: No

Additional Info:
Screenshot of problem: https://i.imgur.com/XypdqTY.png

Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 1 Xisco Faulí 2024-11-27 13:02:53 UTC
@Rafael, I thought you might be interested in this issue
Comment 2 V Stuart Foote 2024-11-27 15:18:16 UTC
Normally, restart of LibreOffice is required to fully change from dark theme to light theme and back.

In tis case, restart does not clear and this control's coloring seems light mode only.
Comment 3 Rafael Lima 2024-11-28 13:20:09 UTC
(In reply to Xisco Faulí from comment #1)
> @Rafael, I thought you might be interested in this issue

This is a Windows-only issue, it does not happen in kf6/gtk3. I've been able to reproduce it on Windows 10 as well.

In the ctor of PageSizeControl it seems to be using an incorrect color. GetMenuColor is not used anywhere else in sw. I'll use GetDialogColor instead.

Here's the proposed fix:
https://gerrit.libreoffice.org/c/core/+/177485