Bug 164153 - Tracked changes: show deletions in margins does not work with tables or frames.
Summary: Tracked changes: show deletions in margins does not work with tables or frames.
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Track-Changes-Table Track-Changes-Frame
  Show dependency treegraph
 
Reported: 2024-12-03 23:18 UTC by lomacar
Modified: 2024-12-07 11:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
test document (14.63 KB, application/vnd.oasis.opendocument.text)
2024-12-03 23:20 UTC, lomacar
Details
screenshot (29.56 KB, image/png)
2024-12-03 23:21 UTC, lomacar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lomacar 2024-12-03 23:18:48 UTC
Description:
Among the other issues with showing deletions in margins, deletions don't display in the margins from tables and frames. Frames have additional quirks.

Steps to Reproduce:
Tables:
1.Create a table with more than one column.
2.Add text to the second column.
3.Turn on tracked changes and delete the text.

Frames:
1. Create a frame.
2. Add text to it.
3. Turn on tracked changes and delete the text.

Actual Results:
Tables: the deletion shows to the immediate left of the cell, in the other table cell.

Frame: the deletion does not appear at all unless there is other text or an overlapping frame/object where the deletion was. When it does appear it is to the immediate left of the frame.

Expected Results:
Deletions should appear in the page margin.


Reproducible: Always


User Profile Reset: No

Additional Info:
That is all.
Comment 1 lomacar 2024-12-03 23:20:25 UTC
Created attachment 197925 [details]
test document

Test document showing buggy behaviour.
Comment 2 lomacar 2024-12-03 23:21:43 UTC
Created attachment 197926 [details]
screenshot
Comment 3 Aryeh 2024-12-03 23:58:02 UTC
I was not able to reproduce the bug. It showed normal behavior for me.

Version: 24.8.2.1 (AARCH64) / LibreOffice Community
Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13
CPU threads: 8; OS: macOS 14.5; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 4 Bryan Zanoli 2024-12-04 06:33:44 UTC
Could not reproduce. Performing steps as described in bug report resulted in expected behavior. 

Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 5 lomacar 2024-12-04 06:37:02 UTC
Weird. I am also using 24.8.3.2 on Windows 10.

Do you guys have deletions in margins turned on, or deletions inline?
Comment 6 Bryan Zanoli 2024-12-04 16:55:39 UTC
My mistake, when showing deletions in margins, you are correct. In my case the text does not appear in the margin at all. Not sure how table deletions should be expected to behave when showing in margin. 

Was there a version of Writer that behaved as you expected?
Comment 7 lomacar 2024-12-05 21:27:28 UTC
I think deletions in margins is a relatively new feature, at least it is new for me, so no, I have never seen it work correctly.

Whether it is a new feature or not it has clearly never been implemented correctly/fully. It has several usability issues and needs attention because deletions in margins should be the default behaviour. With inline deletions you mess up the text flow in the document so you aren't really seeing what the final result looks like.
Comment 8 QA Administrators 2024-12-06 03:13:00 UTC Comment hidden (obsolete)
Comment 9 Bryan Zanoli 2024-12-07 08:33:43 UTC
I agree that it doesn't appear to be working as one would expect it to work. Track changes in margin does not support formatting or document layout changes, but one could imagine the text editing still be properly visible within the margins. Updating ticket status to NEW.