Bug 164271 - Macro Selector dialog allows macros in password protected libraries to be run without entering the password
Summary: Macro Selector dialog allows macros in password protected libraries to be run...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Macro_Manager
  Show dependency treegraph
 
Reported: 2024-12-10 20:43 UTC by Jim Raykowski
Modified: 2024-12-28 03:09 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
video showing steps to repo (1.14 MB, video/x-matroska)
2024-12-10 20:43 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2024-12-10 20:43:02 UTC
Created attachment 198047 [details]
video showing steps to repo

Please see the attached video that shows the following steps to repro.

Steps to reproduce:

1) Menu > Tools > Macros > Organize Macros > Basic…

‘BASIC Macros’ dialog opens

2) Click on the ‘Organizer…’ button

‘Basic Macro Organizer’ dialog opens

3) Click on the ‘Libraries’ tab

4) Click on the ‘New…’ button and add a new library to the ‘My Macros & Dialogs’ location

5) Click on the ‘Password…’ button and set a password for the new library

6) Close the ‘Basic Macro Organizer’ dialog

7) Close the ‘Basic Macros’ dialog

8) Close LibreOffice and restart

9) Menu > Tools > Macros > Organize Macros > Basic…

‘BASIC Macros’ dialog opens

10) In the ‘Macro From’ list, double-click on the library that the password was set for

‘Enter Password’ dialog opens as expected

11) Click on the ‘Cancel’ button

12) Close the ‘BASIC Macros’ dialog

13) Menu > Tools > Macros > Organize Macros > Run Macros…

‘Macro Selector’ dialog opens

14)  In the ‘Library’ list, double-click on the library that the password was set for

Results:

The library entry expands to show the content making the macros to the password-protected library accessible to run. 

Expected results:

The password dialog should open the same as it does for the ‘BASIC Macros’ dialog.

Version: 24.2.7.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 2; OS: Linux 6.8; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:24.2.7-0ubuntu0.24.04.1
Calc: threaded
Comment 1 Roman Kuznetsov 2024-12-26 21:39:47 UTC
Jim, is there the same problem in your new macro manager dialog?
Comment 2 Roman Kuznetsov 2024-12-26 21:43:11 UTC
(In reply to Roman Kuznetsov from comment #1)
> Jim, is there the same problem in your new macro manager dialog?

Yep, the same is there =(

So, I confirm the problem

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 99363538616d41de1c5647adddc49d603c4dec61
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded
Comment 3 Jim Raykowski 2024-12-28 03:09:44 UTC
(In reply to Roman Kuznetsov from comment #2)
> (In reply to Roman Kuznetsov from comment #1)
> > Jim, is there the same problem in your new macro manager dialog?
I think you mean your new macro manager dialog :-)

> 
> Yep, the same is there =(
> 
For me, the experimental Macro Manager dialog asks for a password as expected. The Basic Macro Organizer dialog - Modules tab also asks for a password.

Possibly when trying to repro this you had already entered the password. Once the password is entered it is not asked for again until LO is completely closed and reopened. Closing to the start center is not enough. Also, initially setting the password counts as the password being entered. I think the behavior of only having to enter the password once per session is intended. It might be a bit annoying otherwise.

> So, I confirm the problem
> 
> Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 99363538616d41de1c5647adddc49d603c4dec61
> CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
> Locale: ru-RU (ru_RU.UTF-8); UI: en-US
> Calc: threaded
I think this behavior of the Macro Selector dialog not asking for a password has always been around.