Bug 164490 - Use stronger typed SwClient
Summary: Use stronger typed SwClient
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillCpp
Depends on:
Blocks: Dev-related
  Show dependency tree / graph
 
Reported: 2024-12-27 19:45 UTC by Björn Michaelsen
Modified: 2024-12-28 03:12 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2024-12-27 19:45:32 UTC 
Description:
With this MR/commit:
* https://gerrit.libreoffice.org/c/core/+/179307
* https://github.com/LibreOffice/core/commit/687080c2d284f111fdd1fde1ab768ef924c04aa9

sw::ClientBase<T> can be used instead of SwClient to be more explicit about what the client is listening to (in SwClient, its always a SwModify -- but in ClientBase<T>, T can be any explicit subclass of SwModify).

Candidates for this can be found e.g. with "git grep public.*SwClient sw".

This should make the code more easy to understand as it is more explicit about what is listening to what.


Steps to Reproduce:
.

Actual Results:
.

Expected Results:
.


Reproducible: Always


User Profile Reset: No

Additional Info:
.