Bug 164490 - Use stronger typed SwClient
Summary: Use stronger typed SwClient
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.8.0
Keywords: difficultyMedium, easyHack, skillCpp
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2024-12-27 19:45 UTC by Björn Michaelsen
Modified: 2025-03-21 04:57 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2024-12-27 19:45:32 UTC
Description:
With this MR/commit:
* https://gerrit.libreoffice.org/c/core/+/179307
* https://github.com/LibreOffice/core/commit/687080c2d284f111fdd1fde1ab768ef924c04aa9

sw::ClientBase<T> can be used instead of SwClient to be more explicit about what the client is listening to (in SwClient, its always a SwModify -- but in ClientBase<T>, T can be any explicit subclass of SwModify).

Candidates for this can be found e.g. with "git grep public.*SwClient sw".

This should make the code more easy to understand as it is more explicit about what is listening to what.


Steps to Reproduce:
.

Actual Results:
.

Expected Results:
.


Reproducible: Always


User Profile Reset: No

Additional Info:
.
Comment 1 Commit Notification 2025-03-20 06:57:54 UTC
Akshay Kumar Dubey committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/13c5a3b07e4dd66a80bd20556dffbd96a910bb74

tdf#164490 Use stronger typed SwClient

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2025-03-21 04:57:03 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ef9586eb7de51bd683563bd4caa5c376f687ab47

Revert "tdf#164490 Use stronger typed SwClient"

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.