Bug 164599 - In VBASupport mode, IsNumeric(" + 0 ") must return true
Summary: In VBASupport mode, IsNumeric(" + 0 ") must return true
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:25.8.0 target:25.2.0.2
Keywords:
Depends on:
Blocks: Macro-VBA
  Show dependency treegraph
 
Reported: 2025-01-06 10:00 UTC by Mike Kaganski
Modified: 2025-01-08 12:05 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2025-01-06 10:00:31 UTC
Consider this BASIC code:

 Option VBASupport 1

 Sub Test_IsNumeric()
   MsgBox IsNumeric(" + 0 ")
 End Sub

This code must show "True", because that's what VBA does.
Currently, this gives "False" in LibreOffice.

A different question is, if maybe it should also give "True" in LibreOffice *without* VBASupport; but that needs an own bug, and considered separately, because that is potentially a breaking change.
Comment 1 BogdanB 2025-01-06 13:16:49 UTC
I confirm that this code show "False".

Version: 25.2.0.1 (X86_64) / LibreOffice Community
Build ID: ddb2a7ea3a8857aae619555f1a8743e430e146c9
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 2 Mike Kaganski 2025-01-07 08:56:08 UTC
https://gerrit.libreoffice.org/c/core/+/179865
Comment 3 Commit Notification 2025-01-08 05:03:48 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f8ac9d3311a623fdca64583b08780ea8ebed157c

tdf#164599: Allow space between sign and number in VBASupport mode

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2025-01-08 12:05:02 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/6d9ecc59fc7f1e282f773e81913f660d033f0d68

tdf#164599: Allow space between sign and number in VBASupport mode

It will be available in 25.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.