Bug 164617 - Slide becomes blue when Lights template is applied from Master Slides sidebar
Summary: Slide becomes blue when Lights template is applied from Master Slides sidebar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Laurent Balland
URL:
Whiteboard: target:25.8.0 target:25.2.0.2 target:...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Templates Sidebar-Master-Slides
  Show dependency treegraph
 
Reported: 2025-01-07 05:10 UTC by Aron Budea
Modified: 2025-01-14 10:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (191.08 KB, image/png)
2025-01-07 05:10 UTC, Aron Budea
Details
Screenshot when created from template for reference (265.59 KB, image/png)
2025-01-07 05:10 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2025-01-07 05:10:11 UTC
Created attachment 198407 [details]
Screenshot

Open Impress with an empty presentation, open the Master Slides sidebar, and click on the Lights template among the Available for Use ones.

=> You get a blue slide with circles, ie. the colors aren't applied.

This started happening since the following commit in 25.2:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1da2778bc4df3209689dc32dfa0c91848d384556
author		Laurent Balland <laurent.balland@mailo.fr>	2024-07-30 22:53:59 +0200
committer	Laurent Balland <laurent.balland@mailo.fr>	2024-08-31 16:54:04 +0200

"Update Lights Impress template"

Note that builds before the following commit on 2024-12-28 will also exhibit another issue, leaving the slide blank. Builds after this date are OK in this regard.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=960db01dbfe2f916b91782da03532fae1f836445
Comment 1 Aron Budea 2025-01-07 05:10:58 UTC
Created attachment 198408 [details]
Screenshot when created from template for reference
Comment 2 Laurent Balland 2025-01-07 08:31:08 UTC
I see the problem with many templates, which were supposed to work. I need to dive in it.
Comment 3 Laurent Balland 2025-01-08 16:16:27 UTC
I think I understood the problem: when selecting a master page, only the <office:automatic-styles> section is imported and not the <office:styles> section. This implies that all styles created in the template are lost :-(

This is clearly the case when applying Focus master page: the orange and purple triangles appear blue because they are using styles defined only in template, whereas other triangles keep their color because their style is using automatic style. See https://opengrok.libreoffice.org/xref/core/extras/source/templates/presnt/Focus/styles.xml?r=13d27a60ec301874a5d0d171dcdf86f20e5f7473#1037

1037     <style:master-page style:name="Focus" style:page-layout-name="PM1" draw:style-name="Mdp1">
1038       <draw:polygon draw:style-name="Mgr3" .../>
1039       <draw:polygon draw:style-name="Filled_20_Orange" .../>
1040       <draw:polygon draw:style-name="Mgr5" .../>
1041       <draw:polygon draw:style-name="Mgr6" .../>
1042       <draw:polygon draw:style-name="Mgr7" .../>
1043       <draw:polygon draw:style-name="Filled_20_Purple" .../>

I'm going to fix it asap.
Comment 4 Commit Notification 2025-01-09 06:50:36 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d2c3b27a05bdb4adb8c058b1092f9d88f5e0369b

tdf#164617 Fix Ligths Impress template

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2025-01-09 06:51:38 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4e8775bfa4dbdf392b0e6f89331c2ae33bd68d97

tdf#164617 Fix Focus Impress template

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2025-01-09 19:51:36 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/0cbdc0e8fb46173ee84923579784461c4b91f165

tdf#164617 Fix Focus Impress template

It will be available in 25.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2025-01-09 19:52:38 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/ef7ed8e0aaaf159aacd8f8bb540e06912bd3b46e

tdf#164617 Fix Ligths Impress template

It will be available in 25.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2025-01-12 14:44:37 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c22fb96ce78f0f527134a0a73ded636746bea5a6

tdf#164617 Fix Forestbird Impress template

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Laurent Balland 2025-01-12 14:47:14 UTC
I've fixed for Lights, Focus and Forestbird. I've noticed that Vivid and Yellow Idea have the same horrible blue elements, and I'm going to fix them.

Please let me know if you noticed some other template with the same bug.
Comment 10 Aron Budea 2025-01-12 16:58:06 UTC
Thanks, Laurent! Are there any references for these? Eg. I'm noticing some have serif fonts, others have sans serif, Beehive is one of those that used to have sans serif font, and now has serif.
Comment 11 Aron Budea 2025-01-12 16:58:43 UTC
Not the same bug, though, just a random detail I'm noticing.
Comment 12 Laurent Balland 2025-01-12 17:58:16 UTC
(In reply to Aron Budea from comment #10)
> Thanks, Laurent! Are there any references for these? Eg. I'm noticing some
> have serif fonts, others have sans serif, Beehive is one of those that used
> to have sans serif font, and now has serif.

Adding Heiko as CC because he may have a better overview.
I don't think there are any references. You may find the original template made by the initial authors on some sites like
https://dohliam.github.io/libreoffice-impress-templates/
I used it to find the name of the initial author, but it is not a "reference".

Actually, I think it is on purpose that templates do not use all the same fonts. When using a master page of another template, LibreOffice preserves the fonts you have in your actual presentation, for title and outline.
For instance, Beehive template has sans serif fonts. But if you create a new presentation with DNA template, your titles are serif fonts; selecting Beehive as master page preserves your serif fonts.
Comment 13 Heiko Tietze 2025-01-13 08:43:55 UTC
(In reply to Aron Budea from comment #10)
> I'm noticing some have serif fonts, others have sans serif...
Laurent's work aims to make templates as much as possible independent from the local setup. If you load a template that uses the font <Foo>, which you haven't installed on your system, it will be replaced by <Bar> - and thus might turn out very ugly.

I expect the default to be defined via the standard template. But since all templates have a dedicated font assigned, my test with a different standard template using some other font failed. For example, "Focus" uses "DejaVu Sans" for the "Title" style (and others) - and this font is not installed on my machine.

So all my sermon needs verification, and we should decide whether a template should use Noto Sans, for example, or whatever is used on the system ;-).
Comment 14 Commit Notification 2025-01-13 12:11:41 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cdca03a54d0a1619e24b70822d05b2e82cc2cd25

tdf#164617 Fix Yellow Idea Impress

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2025-01-13 17:44:19 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/57d453d0f1855c42b24b78c804cdfbc92be02d7a

tdf#164617 Fix Vivid Impress template

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Laurent Balland 2025-01-13 17:51:15 UTC
I consider this bug as fixed as the five templates which had blue artefacts are now fixed. If I missed some other template, feel free to reopen this bug report.
Comment 17 Commit Notification 2025-01-14 09:17:52 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/1ff935076f866b0c8f8ac21ba64b8cc1a7de9681

tdf#164617 Fix Vivid Impress template

It will be available in 25.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2025-01-14 09:17:55 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/1c5f964477bcc738ba945a3182c20e0c29431ed5

tdf#164617 Fix Yellow Idea Impress

It will be available in 25.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2025-01-14 10:13:08 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/dae37d71dd1ce057678bece77aef7b05fca299de

tdf#164617 Fix Forestbird Impress template

It will be available in 25.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.