Description: Text string "Compare by:" in the "Handle Duplicate Records" dialog is missing from translation files so LO always displays it in English. Steps to Reproduce: 1. Go to LO's Weblate 2. Search for "Compare by:" Actual Results: The string is missing. Expected Results: The string should be available for translation. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 25.2.0.2 (X86_64) / LibreOffice Community Build ID: 62af784cc06624122f17ee71c7cf13d906cbaed0 CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win Locale: pl-PL (pl_PL); UI: pl-PL Calc: CL threaded
The string is indicated as not translatable here: https://opengrok.libreoffice.org/xref/core/sc/uiconfig/scalc/ui/duplicaterecordsdlg.ui?r=81a6c8704f19a08acb6c56cc39d5f117ee38df75#305 Sahil: thought you might have some thoughts here.
(In reply to Julien Nabet from comment #1) > The string is indicated as not translatable here: > https://opengrok.libreoffice.org/xref/core/sc/uiconfig/scalc/ui/ > duplicaterecordsdlg.ui?r=81a6c8704f19a08acb6c56cc39d5f117ee38df75#305 > > Sahil: thought you might have some thoughts here. that's a mistake on my side, it should be translatable.
patch: https://gerrit.libreoffice.org/c/core/+/180470
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e46f1c492a3ef9727f2d671ae68a646f9b04a639 tdf#164749 make "Compare by: " label in Duplicates dialog translatable It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you Sahil for the quick feedback. Let's put this one to RESOLVED/FIXED since it can't be cherry-picked for 25.2 anyway (see https://wiki.documentfoundation.org/ReleasePlan/25.2). Kityn: it'll be ok on the next major release 25.8.0 (so in August).
(In reply to Julien Nabet from comment #5) > Thank you Sahil for the quick feedback. > > Let's put this one to RESOLVED/FIXED since it can't be cherry-picked for > 25.2 anyway (see https://wiki.documentfoundation.org/ReleasePlan/25.2). > > Kityn: it'll be ok on the next major release 25.8.0 (so in August). Thanks!
(In reply to Julien Nabet from comment #5) > Thank you Sahil for the quick feedback. > > Let's put this one to RESOLVED/FIXED since it can't be cherry-picked for > 25.2 anyway (see https://wiki.documentfoundation.org/ReleasePlan/25.2). Yes it can. The string was pre-existing so only marking it as translatable for point releases is fine. And while we are at it, let's do this one as well: sc/uiconfig/scalc/ui/duplicaterecordsdlg.ui: <property name="label" translatable="no" context="duplicaterecordsdialog|includesheaders">Data contains row/col headers</property> -> https://gerrit.libreoffice.org/c/core/+/180707
(In reply to Gabor Kelemen (allotropia) from comment #7) > (In reply to Julien Nabet from comment #5) > > Thank you Sahil for the quick feedback. > > > > Let's put this one to RESOLVED/FIXED since it can't be cherry-picked for > > 25.2 anyway (see https://wiki.documentfoundation.org/ReleasePlan/25.2). > > Yes it can. The string was pre-existing so only marking it as translatable > for point releases is fine. > > And while we are at it, let's do this one as well: > > sc/uiconfig/scalc/ui/duplicaterecordsdlg.ui: <property > name="label" translatable="no" > context="duplicaterecordsdialog|includesheaders">Data contains row/col > headers</property> > > -> https://gerrit.libreoffice.org/c/core/+/180707 strings.hrc ``` #define STR_DUPLICATERECORDS_DATACONATINSROWHEADERS NC_("STR_DUPLICATERECORDS_DATACONATINSROWHEADERS", "Data contains row headers") #define STR_DUPLICATERECORDS_DATACONATINSCOLUMNHEADERS NC_("STR_DUPLICATERECORDS_DATACONATINSCOLUMNHEADERS", "Data contains column headers") ``` includeheaders is dynamically changed, and is already localized.
(In reply to Gabor Kelemen (allotropia) from comment #7) > ... > Yes it can. The string was pre-existing so only marking it as translatable > for point releases is fine. I didn't know this specific case, great! :-)
(In reply to Sahil Gautam (Allotropia) from comment #8) > strings.hrc > ``` > #define STR_DUPLICATERECORDS_DATACONATINSROWHEADERS > NC_("STR_DUPLICATERECORDS_DATACONATINSROWHEADERS", "Data contains row > headers") > #define STR_DUPLICATERECORDS_DATACONATINSCOLUMNHEADERS > NC_("STR_DUPLICATERECORDS_DATACONATINSCOLUMNHEADERS", "Data contains column > headers") > ``` > includeheaders is dynamically changed, and is already localized. Oh great, thanks for the info :). Did not look into the code. Unfortunately there is no practical way to mark such strings in ui files as intentionally not marked for translation - Glade removes the translatable="no" flag, so something more future-proof needs to be invented.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-25-2": https://git.libreoffice.org/core/commit/6b67e477cffdffc3689a05d91392d4ce12ad9b9a tdf#164749 make "Compare by: " label in Duplicates dialog translatable It will be available in 25.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.