Bug 164835 - non-dummy lines consisting of only tabstops don't wrap around frames - are just lost (comment 7)
Summary: non-dummy lines consisting of only tabstops don't wrap around frames - are ju...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Paragraph-Alignment
  Show dependency treegraph
 
Reported: 2025-01-24 01:50 UTC by Justin L
Modified: 2025-01-27 18:03 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
forum-mso-de-12204.doc_import-compare-0.png: RED=25.2 master, BLUE=25.2 oldest, grayscale=Word 2019 (50.62 KB, image/png)
2025-01-24 01:50 UTC, Justin L
Details
forum-mso-de-12204.doc: the file to test (63.00 KB, application/msword)
2025-01-24 01:52 UTC, Justin L
Details
forum-mso-de-12204.doc_import-compare-0.png: focused image - removed whitespace (437.94 KB, image/png)
2025-01-24 13:04 UTC, Justin L
Details
forum-mso-de-83374.doc: also impacted by the identified commit (126.50 KB, application/msword)
2025-01-24 15:18 UTC, Justin L
Details
forum-mso-de-83374_word2010.png: screenshot of what should be in LO missing "open space" (24.52 KB, image/png)
2025-01-24 15:20 UTC, Justin L
Details
forum-mso-de-83374.doc_import-compare-0.png: red/blue/grayscale overlay image (84.70 KB, image/png)
2025-01-24 15:23 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2025-01-24 01:50:25 UTC
Created attachment 198725 [details]
forum-mso-de-12204.doc_import-compare-0.png: RED=25.2 master, BLUE=25.2 oldest, grayscale=Word 2019

Not enough space was provided to accommodate the Windings symbol at 14pt in this 10pt paragraph. This is noticeable when comparing to MS Word's output.

(This sounds like bug 163956, but the patch for that hasn't resolved the issue.)

The extra space was lost with 25.2 commit f806fc136b3410ec9a1e09320d100c78b33c867b
Author: Oliver Specht on Thu Jun 13 14:49:16 2024 +0200
    tdf#137335 calculate paragraph height in RTF/DOCX

Steps to reproduce
1.) Open mso-de-12204.doc

Notice that the three line paragraph containing the ENVELOPE icon is identically spaced? The first line should have about 50% more space below it to accommodate the height of the enlarged field content, which is specified in DOCX as
<w:r>
  <w:rPr>
    <w:sz w:val="28"/>
  </w:rPr>
  <w:sym w:font="Wingdings" w:char="002A"/>
</w:r>

Found by Collabora's mso-test
Comment 1 Justin L 2025-01-24 01:52:19 UTC
Created attachment 198726 [details]
forum-mso-de-12204.doc: the file to test
Comment 2 Justin L 2025-01-24 13:04:37 UTC
Created attachment 198739 [details]
forum-mso-de-12204.doc_import-compare-0.png: focused image - removed whitespace
Comment 3 Justin L 2025-01-24 15:18:59 UTC
Created attachment 198744 [details]
forum-mso-de-83374.doc: also impacted by the identified commit
Comment 4 Justin L 2025-01-24 15:20:35 UTC
Created attachment 198745 [details]
forum-mso-de-83374_word2010.png: screenshot of what should be in LO missing "open space"
Comment 5 Justin L 2025-01-24 15:23:21 UTC
Created attachment 198746 [details]
forum-mso-de-83374.doc_import-compare-0.png: red/blue/grayscale overlay image
Comment 6 Justin L 2025-01-25 21:45:23 UTC
One problem seems to be in lines that consist of only tab spaces (which completely disappear now), caused by
+  bTmpDummy &= !pPos->InTabGrp()

It breaks:
-forum-mso-de-34519.doc (First three lines - should be tabs+CR, then 4pt CR, then tabs, spaces, field+CR)

-forum-mso-de-83374.doc (pictured in comment 5)

-forum-mso-en4-79154.doc (should have two empty CR directly above table(1))

-ooo104638-1.doc (first para should be tab+CR)


The problem described in comment 0 was triggered by removing 
-   .... && !rInf.GetLineStart()
Comment 7 Justin L 2025-01-26 01:50:39 UTC
(In reply to Justin L from comment #6)
> The problem described in comment 0 was triggered by removing 
> -   .... && !rInf.GetLineStart()
That is perhaps fixed by mistake in LO 7.2, so don't flag that as a regression.
commit 89e7341025b607491c90efdb74708e63d875c1e5
Author: Justin Luth on Thu May 27 14:32:54 2021 +0200
    tdf#142404 sw compat layout: ignore blank size only on one-liners


Similarly, the bTmpDummy looks like it might be a layout failure that is newly triggered. These are all examples where wrapping is occurring. I've seen comments stating that a Dummy line MUST have the same height and ascent.
Comment 8 Justin L 2025-01-27 18:03:15 UTC
(In reply to Justin L from comment #7)
> That is perhaps fixed by mistake in LO 7.2
Definitely fixed by mistake. LO's sizing didn't come from the 14pt macrofield-button, but from a nearby 14pt preserved space.