Bug 165160 - New Appearance "color scheme" looses the distinction between active and not active part of ruler
Summary: New Appearance "color scheme" looses the distinction between active and not a...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
25.2.0.3 release
Hardware: All All
: medium normal
Assignee: Sahil Gautam (allotropia)
URL:
Whiteboard: target:25.8.0 target:25.2.2
Keywords:
Depends on:
Blocks: Rulers LibreOffice-Themes
  Show dependency treegraph
 
Reported: 2025-02-10 10:56 UTC by Regina Henschel
Modified: 2025-02-19 21:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Compare new and old ruler painting (48.50 KB, image/png)
2025-02-10 10:56 UTC, Regina Henschel
Details
ruler color customization (46.48 KB, image/png)
2025-02-19 10:25 UTC, Sahil Gautam (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2025-02-10 10:56:13 UTC
Created attachment 199106 [details]
Compare new and old ruler painting

In the old UI rendering in Automatic scheme, the rulers have a gray background but the part of the ruler that is active, was White. So you have can quickly notice the object area in the ruler.

The new scheme rendering has no setting to give a different color to the active part of the ruler. (At least I have not found it.)

The attached screenshot shows the old and the new rendering side-by-side.
Comment 1 V Stuart Foote 2025-02-10 14:51:22 UTC
Confirmed.

25.2.0.3 Automatic theme in os/DE Win10 System in Light color theme the ruler matches the formatting of the 24.8.6.2, an active shape gets a highlight in what looks to be the document background color.  

But enabling an Appearance theme causes the ruler to show in two tone bg/fg and looses the "highlight" coloring in ruler of an active shape with just "bounding marks" (sort of a break in outline applied to rest of the ruler) for the shape visible in ruler's fg color.

And, with the 2025-02-07 master against 25.8.0--so Appearance theme enable by default, the "highlight" coloring on rulers does not appear, only two-tone coloring and bounding marks in ruler fg color for the selected shape.


STR

1. open writer
2. enable view -> rulers -> vertical ruler
3. insert shape -> basic shape -> rectangle
4. select the shape
5. observe its representation on the vertical and horizontal rulers

Changing to a different Appearance theme changes the fg/bg of the rulers, but still only the two tone fg/bg coloring.
Comment 2 V Stuart Foote 2025-02-10 15:20:26 UTC
Question might be if this visual representation of active Shape(s) on the ruler is really necessary? The "highlighting" has been a good visual queue, and it is what folks were used to, but is now gone. 

But is it worth the effort to try to restore with the new Appearance theme framework, beyond needing some luminance adjustment as with Scrollbars. Maybe not?
Comment 3 Sahil Gautam (allotropia) 2025-02-19 10:25:52 UTC
Created attachment 199306 [details]
ruler color customization

so when themes is enabled, the ruler margins get the window color, and the central part of the ruler gets the base color(the same color used by the list boxes and combo boxes)
Comment 4 Sahil Gautam (allotropia) 2025-02-19 10:35:21 UTC
https://gerrit.libreoffice.org/c/core/+/181879 here goes the patch
Comment 5 V Stuart Foote 2025-02-19 13:00:03 UTC
(In reply to Sahil Gautam (allotropia) from comment #3)
> Created attachment 199306 [details]
> ruler color customization
> 
> so when themes is enabled, the ruler margins get the window color, and the
> central part of the ruler gets the base color(the same color used by the
> list boxes and combo boxes)

Yes I think that is correct, what shows for the list and combo boxes...
Comment 6 Commit Notification 2025-02-19 13:41:53 UTC
Sahil Gautam committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f838f886aab79ef5c09c3f9b4c701cefec9c8576

tdf#165160 active and non-active parts of ruler should be distinctable

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2025-02-19 21:17:49 UTC
Sahil Gautam committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/c4945c3ff5b698991abacd60cbf252857c582549

tdf#165160 active and non-active parts of ruler should be distinctable

It will be available in 25.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.